← Back to issue list

Add https_proxy support to maven plugin.

View original Github issue

Metadata

Project
snapcraft
Number
#570
Type
pull request
State
closed
Author
squidsoup
Labels
—
Created
Updated
Closed

Current evaluation

Closed as superseded by #642, which added https_proxy and proxy authentication support to the Maven plugin and merged as commit 877f54c3f.

Resolution: closed superseded

Reason: The author explicitly marked #570 as superseded by #642. The replacement PR added Maven https_proxy support, including credentials, and was merged in commit 877f54c3f.

Evaluated by: mr-cal-bot

No scores available.

Issue body

No https_proxy configuration is written to the maven configuration file. Snaps using the maven plugin which fetch dependencies over https can't currently be built on launchpad. Ideally I would like to test this change against a ppa on launchpad's test build infrastructure before this is considered for merging. lpbug: https://bugs.launchpad.net/snapcraft/+bug/1592218

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Closed as superseded by #642, which added https_proxy and proxy authentication support to the Maven plugin and merged as commit 877f54c3f.
stealth/space-bunny-alpha — closed superseded Closed unmerged after https_proxy support remained broken in Launchpad testing; superseded by canonical/snapcraft#642, merged as 877f54c3f.
qwen/qwen3.6-35b-a3b — — Adding https_proxy support to the maven plugin was closed and superseded by PR #642. While approved, Launchpad testing was blocked by infrastructure issues, leading the author to replace it with a newer implementation.
qwen3.6-35b-a3b-mtp-q6 — — Superseded by PR #642. The patch aimed to add https_proxy support to the maven plugin but faced Launchpad testing delays. The feature was ultimately implemented and merged via the newer PR.

Update history

No update history recorded yet.

Related work

  • Superseded By: canonical/snapcraft#642 (confidence 100%)

    Merged replacement for the unmerged Maven proxy-support change.

Related issues

Issue Project State Summary Similarity
#642 Make maven plugin honour https_proxy and proxy authentication snapcraft merged Merged as commit 877f54c3f: Maven plugin now honours https_proxy (incl. credentials) when generating settings.xml via ElementTree; SNAPCRAFT_SETUP_PROXIES env var removed.
73%