Make maven plugin honour https_proxy and proxy authentication
Metadata
Current evaluation
Merged as commit 877f54c3f: Maven plugin now honours https_proxy (incl. credentials) when generating settings.xml via ElementTree; SNAPCRAFT_SETUP_PROXIES env var removed.
Resolution: closed resolved
Reason: PR #642 was merged into master as commit 877f54c3f ("Make maven plugin honour https_proxy and proxy authentication (#642)"), confirmed in the history of snapcraft/plugins/maven.py after @sergiusens approved 'ok to test' for LP bug #1598193.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Builds in Launchpad require use of an authenticated proxy, and honouring
https_proxy also seems like a good idea on general principles. I've
switched to using xml.etree.ElementTree to construct settings.xml, as it
was getting more complicated and I'm not a big fan of constructing
non-trivial XML by concatenating strings; this requires the tests to
cope with differing whitespace.
I've dropped the SNAPCRAFT_SETUP_PROXIES environment variable. Having
one environment variable that tells snapcraft to honour another
environment variable seems rather pointless, especially when it doesn't
actually change the contents of the resulting snap, but rather is just
part of the local networking environment that snapcraft needs to work
within.
LP: #1598193
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 877f54c3f: Maven plugin now honours https_proxy (incl. credentials) when generating settings.xml via ElementTree; SNAPCRAFT_SETUP_PROXIES env var removed. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/snapcraft#642 (877f54c3f), making the Maven plugin honor https_proxy and proxy credentials, build settings.xml with ElementTree, and remove SNAPCRAFT_SETUP_PROXIES. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Updated the Maven plugin to respect https_proxy and proxy auth, replaced XML string building with ElementTree, and removed SNAPCRAFT_SETUP_PROXIES. Approved and integrated despite an initial test cleanup error. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Updates the Maven plugin to respect https_proxy and proxy authentication. Replaces string-based XML generation with xml.etree.ElementTree and removes the SNAPCRAFT_SETUP_PROXIES environment variable. Resolves Launchpad bug #1598193. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#1256
(confidence 35%)
Follow-up 'ant plugin: honour proxy configuration' generalising proxy support to other Java plugins.
-
Related To:
canonical/snapcraft#650
(confidence 30%)
Later maven plugin change (maven targets) touching the same file, not a fix for this PR.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #570 Add https_proxy support to maven plugin. | snapcraft | closed | Closed as superseded by #642, which added https_proxy and proxy authentication support to the Maven plugin and merged as commit 877f54c3f. |