← Back to issue list

Remove help and version commands from snapcraft_legacy

View original Github issue

Metadata

Project
snapcraft
Number
#5773
Type
pull request
State
closed
Author
Nalin-Kumar-Gupta
Labels
—
Created
Updated
Closed

Current evaluation

Approved PR #5773 was closed unmerged and superseded by merged PR #5777, which combined its cleanup with #5731 and removed the unused legacy help/version commands.

Resolution: closed superseded

Reason: Maintainer @lengau created #5777 to combine #5773 and #5731 and credit both contributors. PR #5777 subsequently merged and removed the unused legacy help and version commands.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Remove the help and version commands from snapcraft_legacy as they are no longer used. Fixes (#5682) ### Removed Files - `snapcraft_legacy/cli/help.py` - Help command implementation - `snapcraft_legacy/cli/version.py` - Version command implementation - `tests/legacy/unit/commands/test_help.py` - Help command unit tests - `tests/legacy/unit/commands/test_version.py` - Version command unit tests ### Modified Files - `snapcraft_legacy/cli/_runner.py`: - Removed imports for `helpcli` and `versioncli` - Removed both commands from the `command_groups` list - Moved `SNAPCRAFT_VERSION_TEMPLATE` constant locally - [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `make test`? ---

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded Approved PR #5773 was closed unmerged and superseded by merged PR #5777, which combined its cleanup with #5731 and removed the unused legacy help/version commands.
stealth/space-bunny-alpha — closed superseded Cleanup was merged via #5777, which combined #5731 and #5773 and removed unused legacy help/version commands; #5773 closed unmerged.
stealth/space-bunny-alpha — closed superseded #5773 was approved but closed unmerged; its legacy help/version cleanup was combined with #5731 and merged through replacement PR #5777, resolving #5682.
stealth/space-bunny-alpha — closed superseded Closed unmerged after approval because #5777 superseded it; merged #5777 combined #5773 and #5731 to remove the unused legacy help/version commands.
stealth/space-bunny-alpha — closed superseded Approved PR #5773 was closed unmerged when #5777 superseded it, combining the cleanup with #5731. Merged #5777 removed the unused legacy help/version commands and credited both contributors.
qwen/qwen3.6-35b-a3b — — Superseded by PR #5777, which consolidated these changes with PR #5731 to remove unused help and version commands from snapcraft_legacy. Approved by reviewers and passed all CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Superseded by PR #5777, which combined this cleanup with PR #5731 to remove unused help and version commands from snapcraft_legacy. Both contributors received credit for the merged changes.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#5682 (confidence 100%)

    Original tracking issue for removing legacy help and version code.

  • Superseded By: snapcraft#5777 (confidence 100%)

    Merged replacement that incorporated the cleanup from #5773.

  • Related To: snapcraft#5731 (confidence 98%)

    Parallel cleanup combined with #5773 in the superseding PR.

Related issues

Issue Project State Summary Similarity
#5682 Remove legacy help and version code snapcraft closed Merged PR #5777 removed the unused snapcraft_legacy help/version commands and their tests; the legacy package was later removed wholesale for Snapcraft 9.
86%
#5777 chore(legacy-cli): remove unused help and version commands snapcraft closed Merged #5777, removing unused legacy CLI help/version commands after confirming snapcraft_legacy was not exposed in official releases; it combined #5731 and #5773.
81%
#5731 chore(legacy-cli): remove unused help.py and version.py, drop related test snapcraft closed Closed unmerged as superseded by merged #5777, which combined this cleanup with #5773 and removed the unused legacy help/version commands, crediting both contributors.
74%