← Back to issue list

Remove help and version commands from snapcraft_legacy

View original Github issue

Metadata

Project
snapcraft
Number
#5773
Type
pull request
State
closed
Author
Nalin-Kumar-Gupta
Labels
Created
Updated
Closed

Current evaluation

Superseded by PR #5777, which consolidated these changes with PR #5731 to remove unused help and version commands from snapcraft_legacy. Approved by reviewers and passed all CI checks.

Suggested action:

No scores available.

Issue body

Remove the help and version commands from snapcraft_legacy as they are no longer used. Fixes (#5682) ### Removed Files - `snapcraft_legacy/cli/help.py` - Help command implementation - `snapcraft_legacy/cli/version.py` - Version command implementation - `tests/legacy/unit/commands/test_help.py` - Help command unit tests - `tests/legacy/unit/commands/test_version.py` - Version command unit tests ### Modified Files - `snapcraft_legacy/cli/_runner.py`: - Removed imports for `helpcli` and `versioncli` - Removed both commands from the `command_groups` list - Moved `SNAPCRAFT_VERSION_TEMPLATE` constant locally - [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `make test`? ---

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Superseded by PR #5777, which consolidated these changes with PR #5731 to remove unused help and version commands from snapcraft_legacy. Approved by reviewers and passed all CI checks.
qwen3.6-35b-a3b-mtp-q6 Superseded by PR #5777, which combined this cleanup with PR #5731 to remove unused help and version commands from snapcraft_legacy. Both contributors received credit for the merged changes.
qwen3.6-35b-a3b-mtp-q6 Superseded by PR #5777, which merged this cleanup with PR #5731 to remove unused help and version commands from snapcraft_legacy. Both contributors received credit for the combined changes.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#5682 Remove legacy help and version code snapcraft closed Closed as obsolete. The entire snapcraft_legacy module is being removed in Snapcraft 9, rendering the specific cleanup of legacy help and version commands unnecessary. No pull request was merged.
82%
#113 fix: #112 and help messages rockcraft merged Merged. Moves the init command out of lifecycle commands and fixes help messages inherited from snapcraft, resolving issue #112. Approved by reviewer and passed CI.
73%