chore(legacy-cli): remove unused help and version commands
Metadata
Current evaluation
Merged #5777, removing unused legacy CLI help/version commands after confirming snapcraft_legacy was not exposed in official releases; it combined #5731 and #5773.
Resolution: closed resolved
Reason: PR #5777 was merged and removed the unused legacy help and version commands. It incorporated the changes from #5731 and #5773 after maintainers confirmed snapcraft_legacy was not exposed in official Snapcraft packages.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This is a merge of #5731 and #5773, which both implement this change.
Authors: @Serena6688 and @Nalin-Kumar-Gupta
- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `make test`?
---
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #5777, removing unused legacy CLI help/version commands after confirming snapcraft_legacy was not exposed in official releases; it combined #5731 and #5773. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #5777 removed unused legacy CLI help and version commands, combining #5731 and #5773 after confirming snapcraft_legacy was not exposed in official releases. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in PR #5777, combining #5731 and #5773 to remove unused legacy help/version commands after confirming snapcraft_legacy was never exposed in official Snapcraft releases. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after confirming the legacy CLI entrypoint was never exposed in official releases. The unused help and version commands were safely removed, finalizing the cleanup of deprecated legacy code. | |
| qwen/qwen3.8-27b |
Impact:
10
Quick Win:
9
Staleness:
15
Complexity:
10
Confidence:
85
|
close not mergeable | Removes unused legacy CLI help/version commands (merge of #5731 and #5773). Approved, but targets files already deleted when the entire snapcraft_legacy directory was removed in a subsequent commit. | |
| qwen/qwen3.6-35b-a3b |
Staleness:
70
Complexity:
10
Confidence:
90
|
needs review | Removes unused legacy help and version commands. Approved, CI passes aside from unrelated failures. Inactive for ~9 months but maintainers agreed on the approach and it is ready to land. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
90
Complexity:
10
Confidence:
85
|
close stale | Removes unused legacy help and version CLI commands. Discussion confirms the legacy entrypoint isn't exposed in the official snap, making removal safe. Currently inactive for ~9 months. |
Update history
| Date | Change |
|---|---|
| closed | |
| updated |
Related work
-
Related To:
canonical/snapcraft#5731
(confidence 99%)
One of the source PRs combined into the merged cleanup.
-
Related To:
canonical/snapcraft#5773
(confidence 99%)
One of the source PRs combined into the merged cleanup.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #5731 chore(legacy-cli): remove unused help.py and version.py, drop related test | snapcraft | closed | Closed unmerged as superseded by merged #5777, which combined this cleanup with #5773 and removed the unused legacy help/version commands, crediting both contributors. | |
| #6035 chore!: remove deprecated commands | snapcraft | merged | Merged as 3623601d7, removing deprecated Snapcraft commands and options and resolving #5674 (SNAPCRAFT-1196). | |
| #5773 Remove help and version commands from snapcraft_legacy | snapcraft | closed | Approved PR #5773 was closed unmerged and superseded by merged PR #5777, which combined its cleanup with #5731 and removed the unused legacy help/version commands. | |
| #5682 Remove legacy help and version code | snapcraft | closed | Merged PR #5777 removed the unused snapcraft_legacy help/version commands and their tests; the legacy package was later removed wholesale for Snapcraft 9. | |
| #6241 chore: remove snapcraft_legacy | snapcraft | merged | Merged #6241 via commits ffb164b7a and 995f0a3bc, deleting snapcraft_legacy, obsolete specs, and legacy-only dependencies after its entry points were removed. | |
| #6472 chore: remove unused set_legacy_env | snapcraft | closed | Closed unmerged; author superseded it by reworking branch layout to work/refactor/* and pushing directly to canonical/snapcraft. | |
| #1078 chore!: remove deprecated APIs | craft-application | merged | Merged PR #1078 as 3334f13e, removing eight deprecated APIs and fixing #1063. All CI checks passed, with local Snapcraft verification. | |
| #6074 chore!: remove default command | snapcraft | merged | PR #6074 merged as db7c53f21, removing bare snapcraft packing for #5673; #6178 later reverted the change in e5aaf0683. | |
| #5821 chore(legacy): remove script entry point | snapcraft | merged | Merged as f8cf41382, removing the obsolete legacy script entry point to resolve confusion raised in #5778. | |
| #3682 cli: fix help command legacy fallback | snapcraft | merged | Merged #3682 as commit 468051ea5, handling craft-cli's ProvideHelpException so legacy help prints the same message as --help and exits successfully. |