← Back to issue list

`git describe` in an `override-build` is always claiming to be dirty

View original Github issue

Metadata

Project
snapcraft
Number
#5831
Type
issue
State
open
Author
lengau
Labels
Status: Triaged Type: Bug
Created
Updated
Closed
—

Current evaluation

Bug where git describe --dirty in an override-build always reports the repo as dirty because spread.yaml and spread/.extension are not copied into the build directory, causing Charmcraft 4.0.0 to appear dirty. Triaged and synced to internal ticket SNAPCRAFT-1251.

Suggested action: keep open

Reason: The issue is labeled Status: Triaged and Type: Bug, and was synced to internal ticket SNAPCRAFT-1251, indicating it has been assessed by maintainers. The related craft-application#942 issue with the same title is closed and was fixed by updating source ignore patterns for spread files in lifecycle.py, suggesting this is a real bug that was addressed upstream. However, since this issue in the charmcraft repo is still open and the fix may need to be backported or verified, it should remain open until confirmed resolved.

Impact: 50 Quick Win: 30.0 Staleness: 65 Complexity: 40 Confidence: 75 Support Request: 5

Issue body

### Bug Description If you have a `spread/.extension` file, `git describe --dirty` in an override-build will always show the repo as dirty because `spread.yaml` and `spread/.extension` don't get copied into the build directory. This is causing Charmcraft 4.0.0 to appear to be dirty. ### To Reproduce Check out the 4.0.0 tag of Charmcraft and pack it ### Environment My machine, launchpad, etc... ### snapcraft.yaml ```yaml ... ``` ### Relevant log output ```shell n/a ``` ### Additional context _No response_

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.8-27b
Impact: 50
Quick Win: 30.0
Staleness: 65
Complexity: 40
Confidence: 75
Support Request: 5
keep open Bug where git describe --dirty in an override-build always reports the repo as dirty because spread.yaml and spread/.extension are not copied into the build directory, causing Charmcraft 4.0.0 to appear dirty. Triaged and synced to internal ticket SNAPCRAFT-1251.
qwen/qwen3.6-35b-a3b
Staleness: 85
Complexity: 45
Confidence: 75
Support Request: 5
keep open Bug where git describe --dirty in override-build incorrectly reports the repo as dirty because spread files are not copied to the build directory. Currently triaged but inactive for over nine months.
qwen3.6-35b-a3b-mtp-q6
Staleness: 75
Complexity: 45
Confidence: 85
Support Request: 10
keep open Bug where git describe --dirty in override-build incorrectly reports the repo as dirty due to missing spread files in the build directory. Triaged but inactive for 265 days.
qwen3.6-35b-a3b-mtp-q6
Staleness: 65
Complexity: 30
Confidence: 85
Support Request: 5
keep open git describe --dirty incorrectly reports the repository as dirty during override-build because spread files are not copied to the build directory. Triaged and tracked as SNAPCRAFT-1251, awaiting implementation.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: craft-application#942 (confidence 80%)

    Same title and description; craft-application#942 is closed and was fixed by updating source ignore patterns for spread files in lifecycle.py, which directly addresses the root cause of git describe reporting dirty due to spread files not being copied into the build directory.

Related issues

Issue Project State Summary Similarity
#942 git describe in an override-build is always claiming to be dirty craft-application closed Resolved by updating craft-application's lifecycle service to correctly handle spread file ignore patterns, preventing false dirty status in override-builds.
78%