← Back to issue list

fix(LifecycleService): pull local test files

View original Github issue

Metadata

Project
craft-application
Number
#1013
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged craft-application#1013 (commit f4a4d282) fixed LifecycleService local-source handling: test files are copied without modifications triggering rebuilds; cryptography was also bumped for an OSV.

Resolution: closed resolved

Reason: PR canonical/craft-application#1013 was merged in commit f4a4d282. It passes the outdated-file exclusions needed to pull local test files while ignoring their modifications, resolving canonical/craft-application#942; the PR also explicitly unblocks canonical/snapcraft#5831.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- This PR consumes the fixes from https://github.com/canonical/craft-parts/pull/1383. Test files are no longer excluded when pulling a local source. Modifications to test files still don't cause the lifecycle to rebuild. I added a spread test to verify both of these behaviors. Also bumps cryptography for an OSV. Fixes #942 Unblocks https://github.com/canonical/snapcraft/issues/5831 (CRAFT-4883)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged craft-application#1013 (commit f4a4d282) fixed LifecycleService local-source handling: test files are copied without modifications triggering rebuilds; cryptography was also bumped for an OSV.
stealth/space-bunny-alpha — closed resolved Merged CRAFT-4883 fix: local test files are now pulled without their modifications triggering rebuilds; cryptography was also bumped for an OSV.
stealth/space-bunny-alpha — closed resolved Merged in craft-application#1013 (f4a4d282): local sources now include test files without triggering rebuilds; incorporates craft-parts#1383, adds tests, and bumps cryptography for an OSV.
qwen/qwen3.6-35b-a3b — — Merged following successful CI checks and approvals. Resolves #942 by fixing LifecycleService to pull local test files, updates the cryptography dependency, and adds verification tests. Unblocks snapcraft issue #5831.
qwen3.6-35b-a3b-mtp-q6 — — Merged fix resolving issue #942 by updating LifecycleService to include local test files during pull operations. Added a spread test for verification, bumped the cryptography dependency, and unblocked downstream snapcraft builds.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/craft-application#942 (confidence 100%)

    The PR explicitly states it fixes #942, and the issue resolution is linked to commit f4a4d282.

  • Related To: canonical/craft-parts#1383 (confidence 100%)

    The PR states that it consumes the fixes from this merged upstream PR.

  • Related To: canonical/snapcraft#5831 (confidence 95%)

    The PR explicitly identifies this Snapcraft issue as unblocked.

  • Related To: canonical/craft-parts#1373 (confidence 90%)

    Upstream craft-parts#1383 fixed this issue by pulling files excluded from outdated checks.

Related issues

Issue Project State Summary Similarity
#766 fix(lifecycle): don't rebuild on test file changes craft-application merged Merged PR canonical/craft-application#766 excluded spread test files from lifecycle outdated checks, preventing test-only changes from repulling local source parts and resolving #756.
80%