fix(LifecycleService): pull local test files
Metadata
Current evaluation
Merged following successful CI checks and approvals. Resolves #942 by fixing LifecycleService to pull local test files, updates the cryptography dependency, and adds verification tests. Unblocks snapcraft issue #5831.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint && make test`?
- [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
This PR consumes the fixes from https://github.com/canonical/craft-parts/pull/1383.
Test files are no longer excluded when pulling a local source. Modifications to test files still don't cause the lifecycle to rebuild. I added a spread test to verify both of these behaviors.
Also bumps cryptography for an OSV.
Fixes #942
Unblocks https://github.com/canonical/snapcraft/issues/5831
(CRAFT-4883)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged following successful CI checks and approvals. Resolves #942 by fixing LifecycleService to pull local test files, updates the cryptography dependency, and adds verification tests. Unblocks snapcraft issue #5831. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix resolving issue #942 by updating LifecycleService to include local test files during pull operations. Added a spread test for verification, bumped the cryptography dependency, and unblocked downstream snapcraft builds. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for LifecycleService to include local test files during pulls, resolving issue #942. Integrates upstream craft-parts changes, adds a spread test to verify behavior, and bumps the cryptography dependency. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #892 fix(Lifecycle): don't cache the project | craft-application | merged | Merged a fix preventing project caching in the lifecycle module. Approved by two reviewers and passed all CI checks. The change modifies seven files and was validated via downstream snapcraft testing and passing spread tests. | |
| #1877 tests: move test files out of the snapcraft dir | snapcraft | closed | Approved and passing local tests, the changes to move test files out of the snapcraft directory were abandoned after a merge conflict arose. The maintainer closed the request to retry the file relocation later. | |
| #766 fix(lifecycle): don't rebuild on test file changes | craft-application | merged | Merged fix that adds spread files to the lifecycle manager's ignore list, preventing unnecessary repulls when test files change. Approved by two reviewers, passed all CI checks, and resolves issue #756. |