← Back to issue list

style: fix pending lints from snapcraft itself

View original Github issue

Metadata

Project
snapcraft
Number
#5850
Type
pull request
State
merged
Author
bepri
Labels
Created
Updated
Closed

Current evaluation

Merged changes fixing pending snapcraft lint warnings for unused libraries and missing metadata fields. Approved by two reviewers, passed CI checks, and added 10 lines to one file.

Suggested action:

No scores available.

Issue body

- [ ] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `make test`? --- Fixes the following lint warnings (except for the classic linter): ``` ❯ /snap/bin/snapcraft pack Lint OK: - classic: Snap confinement is set to classic. Lint warnings: - library: libicuio.so.74: unused library 'usr/lib/x86_64-linux-gnu/libicuio.so.74.2'. (https://documentation.ubuntu.com/snapcraft/stable/how-to/debugging/use-the-library-linter) - library: libicutest.so.74: unused library 'usr/lib/x86_64-linux-gnu/libicutest.so.74.2'. (https://documentation.ubuntu.com/snapcraft/stable/how-to/debugging/use-the-library-linter) Lint information: - metadata: Metadata field 'contact' is missing or empty. (https://documentation.ubuntu.com/snapcraft/stable/reference/project-file/snapcraft-yaml/#contact) - metadata: Metadata field 'donation' is missing or empty. (https://documentation.ubuntu.com/snapcraft/stable/reference/project-file/snapcraft-yaml/#donation) ```

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged changes fixing pending snapcraft lint warnings for unused libraries and missing metadata fields. Approved by two reviewers, passed CI checks, and added 10 lines to one file.
qwen3.6-35b-a3b-mtp-q6 Merged changes fixing pending snapcraft lint warnings by removing unused library references and populating missing contact and donation metadata fields.
qwen3.6-35b-a3b-mtp-q6 Merged. Resolved pending snapcraft lint warnings by removing unused library references and adding missing contact and donation metadata fields to the project configuration.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2222 style: fix linting issues charmcraft merged Merged following approval by two reviewers. Resolved linting issues across three files with minor style adjustments (+8/-9 lines). No review comments or CI checks were required.
78%
#20 style: fix linting issues craft-artifacts merged Merged after passing all CI checks and receiving approval from two reviewers. The change resolves linting issues across four files with a +11/-5 line diff, updating code style compliance.
77%
#4101 lint: prepare instance for linting a snap file snapcraft merged Merged into main. Updates snapcraft lint to prepare and re-execute inside a snap instance. Approved by a reviewer, passed CI, and increased coverage by 0.02%. Addresses CRAFT-1690.
76%
#4095 cli: add lint command snapcraft merged Merged into main after approval and passing CI checks. Introduces a new snapcraft lint CLI command, adding 223 lines across 5 files with 96.25% test coverage. Resolves CRAFT-1688.
76%
#5 style(lint): fix linting issues starflow merged Merged after approval. Resolved linting issues by modifying one file with three additions and three deletions. No unresolved comments or CI checks were present.
76%
#4028 linters: add linter check for unused libraries snapcraft merged Merged following reviewer approval and successful CI checks. Adds a linter warning to flag unused libraries packaged into snaps. The update modifies 22 files with 449 additions and 40 deletions across five commits.
74%
#3847 linters: add linting infrastructure snapcraft merged Merged. Adds basic linting infrastructure to snapcraft, including a lint entry in snapcraft.yaml to disable specific linters before packing. JSON output is implemented for future use. Approved, rebased, and passed coverage checks.
73%
#1588980 Fix lintian errors snapcraft (launchpad) closed Lintian errors in snapcraft packages were fixed by correcting descriptions, adding manpages, fixing a spelling error, and replacing an embedded jQuery file. Verification confirmed all warnings and errors were resolved.
73%
#2229 style: fix linting errors charmcraft merged Merged changes resolving linting errors from the latest ruff and pyright. Approved by two reviewers with zero unresolved comments. Updated 8 files, removing 22 lines overall.
73%
#165 style: fix linting for ruff 0.12 imagecraft merged Merged a pre-emptive linting update for ruff 0.12 compatibility. Approved by two reviewers and passed CI. The change adjusts formatting across four files to prevent breaking changes when the snap reaches stable.
72%