← Back to issue list

style: fix pending lints from snapcraft itself

View original Github issue

Metadata

Project
snapcraft
Number
#5850
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #5850 as commit bc10f1dc1, resolving Snapcraft's pending lint warnings by excluding unused ICU libraries and adding missing contact and donation metadata.

Resolution: closed resolved

Reason: PR canonical/snapcraft#5850 was approved by two reviewers and merged as bc10f1dc1. Repository history confirms the commit changed snap/snapcraft.yaml to address the reported lint warnings.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `make test`? --- Fixes the following lint warnings (except for the classic linter): ``` ❯ /snap/bin/snapcraft pack Lint OK: - classic: Snap confinement is set to classic. Lint warnings: - library: libicuio.so.74: unused library 'usr/lib/x86_64-linux-gnu/libicuio.so.74.2'. (https://documentation.ubuntu.com/snapcraft/stable/how-to/debugging/use-the-library-linter) - library: libicutest.so.74: unused library 'usr/lib/x86_64-linux-gnu/libicutest.so.74.2'. (https://documentation.ubuntu.com/snapcraft/stable/how-to/debugging/use-the-library-linter) Lint information: - metadata: Metadata field 'contact' is missing or empty. (https://documentation.ubuntu.com/snapcraft/stable/reference/project-file/snapcraft-yaml/#contact) - metadata: Metadata field 'donation' is missing or empty. (https://documentation.ubuntu.com/snapcraft/stable/reference/project-file/snapcraft-yaml/#donation) ```

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #5850 as commit bc10f1dc1, resolving Snapcraft's pending lint warnings by excluding unused ICU libraries and adding missing contact and donation metadata.
stealth/space-bunny-alpha — closed resolved Merged PR #5850 (bc10f1dc1) fixed Snapcraft's own lint findings by ignoring unused ICU libraries and adding missing contact and donation metadata.
stealth/space-bunny-alpha — closed resolved Merged PR #5850 as commit bc10f1dc1, resolving Snapcraft's own pending lint findings for unused ICU libraries and missing contact/donation metadata.
stealth/space-bunny-alpha — closed resolved Merged as bc10f1dc1, PR #5850 removed unused ICU libraries from Snapcraft's own snap and added contact and donation metadata, clearing the pending warnings except classic.
stealth/space-bunny-alpha — closed resolved Merged PR #5850 (bc10f1dc1) resolved pending Snapcraft lint warnings for unused ICU libraries and added missing contact and donation metadata.
stealth/space-bunny-alpha — closed resolved Merged PR #5850 as commit bc10f1dc1, adding Snapcraft contact metadata and suppressing unused libicu library lint warnings.
qwen/qwen3.6-35b-a3b — — Merged changes fixing pending snapcraft lint warnings for unused libraries and missing metadata fields. Approved by two reviewers, passed CI checks, and added 10 lines to one file.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes fixing pending snapcraft lint warnings by removing unused library references and populating missing contact and donation metadata fields.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#561 Fix or address lintian errors and warnings snapcraft merged Merged in canonical/snapcraft#561 via commit 21360d22c, addressing most Lintian errors and warnings; one description-synopsis article warning remained.
76%
#1588980 Fix lintian errors snapcraft (launchpad) closed Lintian warnings/errors (synopsis phrasing, missing manpages, changelog spelling, embedded jQuery in snapcraft-examples) fixed by merged PR #561 (commit 21360d22c). Shipped in snapcraft 2.11 xenial and 2.12+16.10; verified in -updates, tagged verification-done.
72%
#1204 style: fix linting issues craft-parts closed Lint-only cleanup landed in commit a0622b31, matching PR #1204’s title; all reported CI checks passed.
72%
#5795 fix: properly ignore source-code field in metadata linter snapcraft merged Merged PR #5795 as commit 11898bc89, fixing #5794 so the hyphenated source-code metadata field is ignored by the linter; shipped in Snapcraft 8.13.0.
72%
#4095 cli: add lint command snapcraft merged Merged PR #4095 (commit 297130c4e) adding the `snapcraft lint` CLI command with unit tests for CRAFT-1688, giving Snapcraft users access to lint checks.
71%
#3847 linters: add linting infrastructure snapcraft merged Merged into main as 9f70a0422, adding the linting framework, snapcraft.yaml lint configuration, pre-pack lint execution, and JSON-formatted issue output.
70%