← Back to issue list

list-plugins in one column for integration tests

View original Github issue

Metadata

Project
snapcraft
Number
#606
Type
pull request
State
closed
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

PR #606 (single-column list-plugins output) closed unmerged after its approach still failed on column-width variation; superseded by merged PR #607 (commit 3fa8595f0) using per-plugin assertions.

Resolution: closed superseded

Reason: The single-column approach failed in CI due to environment-dependent column widths (see come-maiz's failure output). Leo Arias proposed alternative PR #607, which sergiusens endorsed and which was merged as commit 3fa8595f0 ('Simplify the list plugins integration test (#607)'), simplifying the test with per-plugin assertIn checks instead of brittle format-specific output.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This minimizes discrepancies in expectations depending on where this test is run. LP: #1596114 Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed superseded PR #606 (single-column list-plugins output) closed unmerged after its approach still failed on column-width variation; superseded by merged PR #607 (commit 3fa8595f0) using per-plugin assertions.
stealth/space-bunny-alpha — closed superseded Closed unmerged after column output varied by environment; superseded by merged #607 (commit 3fa8595f0), which uses per-plugin assertions instead of one-column formatting checks.
stealth/space-bunny-alpha — closed superseded Closed without merging after one-column output assertions failed CI; replaced by merged PR #607, which simplified list-plugins integration testing with per-plugin assertions.
qwen/qwen3.6-35b-a3b — — Closed without merging. The change failed CI due to multi-column output discrepancies. It was superseded by PR #607, which replaces the formatting approach with multiple assertIn checks to verify plugin presence.
qwen3.6-35b-a3b-mtp-q6 — — Superseded by PR #607. The single-column formatting attempt failed in CI. Reviewers recommended using multiple assertIn checks instead, so a new branch was proposed to resolve the test discrepancy without relying on output formatting.

Update history

No update history recorded yet.

Related work

  • Superseded By: ubuntu-core/snapcraft#607 (confidence 99%)

    Alternative PR by come-maiz replacing the one-column formatting approach; merged as commit 3fa8595f0.

  • Likely Fixed By: ubuntu-core/snapcraft#607 (confidence 95%)

    The merged PR that actually changed the list-plugins integration test to resolve the flakiness.

Related issues

Issue Project State Summary Similarity
#607 Simplify the list plugins integration test snapcraft merged Merged PR #607 as commit 3fa8595f0, simplifying the list-plugins integration test by removing brittle output-format assertions that required updates whenever plugins were added.
76%
#31 list-plugins command snapcraft closed Added the list-plugins command in commit 32669b7a3; maintainer Sergio Schvezov confirmed it works as expected and its tests pass, then closed the issue.
70%