Simplify the list plugins integration test
Metadata
Current evaluation
Merged PR #607 as commit 3fa8595f0, simplifying the list-plugins integration test by removing brittle output-format assertions that required updates whenever plugins were added.
Resolution: closed resolved
Reason: PR #607 was merged and landed as commit 3fa8595f0, retaining the integration check while removing unnecessary plugin-list format assertions.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This test has been unnecessarily painful to maintain, because every time
we add a new plugin, the format is changed. We don't need to check the format
anymore, and there is little risk of this breaking because the mechanism has been
extensively tested already.
LP: #1596114
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #607 as commit 3fa8595f0, simplifying the list-plugins integration test by removing brittle output-format assertions that required updates whenever plugins were added. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #607 (commit 3fa8595f0, LP: #1596114) simplified the list-plugins integration test, dropping per-plugin format assertions so new plugins no longer required test changes (+14/-6, 1 file). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcraft#607 via commit 3fa8595f0, simplifying the list-plugins integration test by removing brittle, format-specific assertions that changed whenever plugins were added. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged changes simplifying the list plugins integration test by removing unnecessary format checks. A reviewer noted the update addressed a different bug than reported and suggested a changelog entry. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes simplifying the list plugins integration test by removing format validation. Maintenance overhead is reduced since the mechanism is already thoroughly tested. A reviewer noted the linked bug reference was incorrect and requested a changelog update. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft (launchpad)#1596114
(confidence 90%)
Launchpad item linked from the PR body; a maintainer noted this test cleanup did not fix the bug reported there.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1795859 make list plugins tests use mocked plugins | snapcraft (launchpad) | closed | PR snapcraft#2315 was merged as commit 5eb674f4d, updating list-plugins tests to use mocked results so plugin additions or removals no longer require formatting-test edits. | |
| #2315 tests: use mocked plugins for list-plugins | snapcraft | merged | Merged in commit 5eb674f4d (#2315), updating list-plugins tests to use mocked plugins; the test change was extracted from #2308 and addressed LP #1795859. | |
| #606 list-plugins in one column for integration tests | snapcraft | closed | PR #606 (single-column list-plugins output) closed unmerged after its approach still failed on column-width variation; superseded by merged PR #607 (commit 3fa8595f0) using per-plugin assertions. | |
| #1596112 list-plugins integration test is broken when run in adt | snapcraft (launchpad) | closed | Fixed by merged PR #607 (commit 3fa8595f0), replacing brittle list-plugins output assertions; snapcraft 2.12 was verified and released to xenial -updates. |