parser - Don't allow duplicate wiki entries.
Metadata
Current evaluation
Merged PR snapcraft#613 as commit 30e7f4207: the legacy parts parser now keeps the first wiki entry, emits a warning for duplicates and skips them. Fixes LP bug #1597057.
Resolution: closed resolved
Reason: The PR was merged into master as commit 30e7f4207 ("parser - Don't allow duplicate wiki entries. (#613)"), resolving LP bug #1597057. A reviewer request to fold this into the error-code rework was later addressed by merged PR #658 (commit bda3b100e, "parser - Return non-zero code for wiki errors.").
Evaluated by: mr-cal-bot
Issue body
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR snapcraft#613 as commit 30e7f4207: the legacy parts parser now keeps the first wiki entry, emits a warning for duplicates and skips them. Fixes LP bug #1597057. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged to snapcraft master as commit 30e7f4207: wiki parser now keeps the first entry and warns/skips duplicates (LP:#1597057). Reviewer sergiusens landed it as-is. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/snapcraft#613 (30e7f4207): the parser now keeps the first wiki entry, warns about duplicates, and skips them. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as PR #613, commit 30e7f4207: the parser now retains the first wiki entry, warns about duplicates, and skips them. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/snapcraft#613 as commit 30e7f4207: the parser retains the first wiki entry, warns about duplicates, and skips them. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in PR #613 via commit 30e7f4207: the parser now keeps the first wiki entry, warns about duplicates, and skips them. Linked LP bug #1597057. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged the parser update to prevent duplicate wiki entries. The first entry is retained while duplicates trigger a warning and are skipped. The maintainer landed the change as-is, requesting future consideration for error code return values during a separate rework. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Parser retains first wiki entry and warns while skipping duplicates. Approved by @come-maiz and merged by @sergiusens, who noted the approach should be considered during a future error code rework. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/snapcraft#658
(confidence 70%)
Follow-up rework requested by sergiusens in the PR thread; merged as bda3b100e to return non-zero exit codes for wiki parse errors including duplicates.
-
Related To:
canonical/snapcraft#636
(confidence 45%)
Nearby parser hardening commit 'parser - Handle malformed wiki entries. (#636)' in the same legacy parts parser series.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1597057 The parser should not overwrite when duplicate 'project-part's are found in the wiki. | snapcraft (launchpad) | closed | Merged PR #613 (commit 30e7f4207): the parser now retains the first duplicate wiki project-part and skips later duplicates. | |
| #1593390 Need better error handling in the parser | snapcraft (launchpad) | closed | Fixed by merged PR canonical/snapcraft#581 ("Make most wiki fields required. Bugs/1593390"), which tightened snapcraft-parser wiki entry validation so bad entries error instead of silently defaulting. | |
| #636 parser - Handle malformed wiki entries. | snapcraft | merged | Merged parser resilience fix for malformed wiki entries: documents are parsed independently, and integration tests use a fake server (#636, commit 0e3613ab4). |