← Back to issue list

parser - Handle malformed wiki entries.

View original Github issue

Metadata

Project
snapcraft
Number
#636
Type
pull request
State
merged
Author
josepht
Labels
—
Created
Updated
Closed

Current evaluation

Merged parser resilience fix for malformed wiki entries: documents are parsed independently, and integration tests use a fake server (#636, commit 0e3613ab4).

Resolution: closed resolved

Reason: PR #636 was merged as commit 0e3613ab4, isolating wiki entries so one invalid YAML document does not block parsing the rest.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- Split wiki into separate entries so that a YAML error in one document does not stop the parser from parsing the rest of the documents. - Use a FakeServer for integration tests. LP:#1599598

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged parser resilience fix for malformed wiki entries: documents are parsed independently, and integration tests use a fake server (#636, commit 0e3613ab4).
stealth/space-bunny-alpha — closed resolved Merged parser fix splitting wiki content into separate entries so one malformed YAML document no longer prevents parsing others; integration tests use FakeServer.
qwen/qwen3.6-35b-a3b — — Merged. The parser now splits wiki entries into separate documents to prevent YAML errors from halting parsing. A FakeServer was added for integration tests. The changes passed CI and were successfully merged.
qwen3.6-35b-a3b-mtp-q6 — — Merged. The parser now processes wiki entries as separate documents, preventing a single YAML error from halting the entire parsing process. Integration tests were added using a FakeServer. The change was merged after successful CI retests.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#613 parser - Don't allow duplicate wiki entries. snapcraft merged Merged PR snapcraft#613 as commit 30e7f4207: the legacy parts parser now keeps the first wiki entry, emits a warning for duplicates and skips them. Fixes LP bug #1597057.
76%
#1593390 Need better error handling in the parser snapcraft (launchpad) closed Fixed by merged PR canonical/snapcraft#581 ("Make most wiki fields required. Bugs/1593390"), which tightened snapcraft-parser wiki entry validation so bad entries error instead of silently defaulting.
72%
#1599598 The parser should not fail on malformed yaml snapcraft (launchpad) closed Malformed wiki YAML entries no longer abort parsing; fixed by merged PR #636 in commit 0e3613ab4.
71%
#658 parser - Return non-zero code for wiki errors. snapcraft merged Merged PR #658 as commit bda3b100e, making the parser return a non-zero exit code when wiki parsing errors are found.
70%