← Back to issue list

refactor: migrate register-key

View original Github issue

Metadata

Project
snapcraft
Number
#6151
Type
pull request
State
merged
Author
mr-cal
Labels
PR: Rebase
Created
Updated
Closed

Current evaluation

Migrated the register-key command and fixed a regression that incorrectly made key-name non-optional. Approved by three reviewers, rebased, and merged.

Suggested action: —

No scores available.

Issue body

Migrates the `register-key` command. I also fixed a regression that was preventing me from testing most of migrated code. The regression is that `key-name` used to be optional, but it was accidentally made non-optional in the [passthrough command](https://github.com/canonical/snapcraft/pull/3735/changes#diff-f4f8eb6143aff81afbff314d351e97f4719614ba8283c0bb6e29917789b9a479R299-R301). (SNAPCRAFT-1317) --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [x] I've added or updated any relevant documentation. - [x] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Migrated the register-key command and fixed a regression that incorrectly made key-name non-optional. Approved by three reviewers, rebased, and merged.
qwen3.6-35b-a3b-mtp-q6 — — Migrated the register-key command and restored the optional key-name parameter, fixing a regression from a previous passthrough change. Merged after rebasing to clear unrelated CI failures.
qwen3.6-35b-a3b-mtp-q6 — — Migrated the register-key command and fixed a regression that incorrectly made key-name non-optional in the passthrough command. After rebasing to resolve unrelated CI failures, the changes were merged by maintainer mr-cal.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3809 store: correct login for register-key snapcraft merged Merged into main following reviewer approval and passing CI checks. The change corrects login handling for register-key by implementing proper exit handling on errors. The commit adds 23 lines and removes 1 across two files.
70%