store: correct login for register-key
Metadata
Current evaluation
Merged into main following reviewer approval and passing CI checks. The change corrects login handling for register-key by implementing proper exit handling on errors. The commit adds 23 lines and removes 1 across two files.
Suggested action: —
No scores available.
Issue body
Additional measures for proper exit handling on errors
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `make lint`?
- [ ] Have you successfully run `pytest tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged into main following reviewer approval and passing CI checks. The change corrects login handling for register-key by implementing proper exit handling on errors. The commit adds 23 lines and removes 1 across two files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged fix for store login handling during register-key operations. Adds proper exit handling on errors. Approved and integrated into main without coverage changes. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into main. Corrects login handling for the register-key command and implements proper exit handling on errors. Approved by @mr-cal with no coverage impact. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3808 store: login requires no exported credentials | snapcraft | merged | Merged into main following reviewer approval and passing CI. The update modifies store login to require no exported credentials, changing 3 files (+29/-4 lines). Code coverage increased by 0.01% with 100% diff coverage. | |
| #6151 refactor: migrate register-key | snapcraft | merged | Migrated the register-key command and fixed a regression that incorrectly made key-name non-optional. Approved by three reviewers, rebased, and merged. |