← Back to issue list

refactor: migrate release models

View original Github issue

Metadata

Project
snapcraft
Number
#6236
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged after two approvals. Refactored Revision, Release, and Releases models from snapcraft_legacy to Pydantic, simplifying implementation. Unrelated spread test failures were noted but did not block the merge.

Suggested action:

No scores available.

Issue body

Migrates the Revision, Release, and Releases models from snapcraft_legacy. These have been refactored into Pydantic models, which simplifies their implementation. (SNAPCRAFT-1332) --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after two approvals. Refactored Revision, Release, and Releases models from snapcraft_legacy to Pydantic, simplifying implementation. Unrelated spread test failures were noted but did not block the merge.
qwen3.6-35b-a3b-mtp-q6 Merged by mr-cal, this change migrates the Revision, Release, and Releases models from snapcraft_legacy to simplified Pydantic implementations. The update addresses SNAPCRAFT-1332 and passed CI checks despite minor unrelated spread failures.
qwen3.6-35b-a3b-mtp-q6 Merged by maintainer mr-cal. Refactored Revision, Release, and Releases models from snapcraft_legacy to Pydantic for simplified implementation. Unrelated test failures were noted in a follow-up comment.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1117 refactor: move some pydantic models and metafiles charmcraft merged Merged a refactoring change that relocated Pydantic models and metafiles to resolve circular imports. Approved by one reviewer, the update modified 29 files (+667/-520 lines) and closed CRAFT-1746.
71%
#6208 refactor: migrate validate command snapcraft merged Merged via squash. Refactored the gated command and migrated the validate command from legacy to modern Snapcraft, implementing a new Pydantic model for validation assertions across 21 files.
70%