← Back to issue list

refactor: migrate kernel_build

View original Github issue

Metadata

Project
snapcraft
Number
#6237
Type
pull request
State
merged
Author
mr-cal
Labels
PR: Squash PR: Run Manual Spread
Created
Updated
Closed

Current evaluation

Merged #6237 in commit 0f576502e, migrating kernel_build from snapcraft_legacy to modern linting and type-checking standards.

Resolution: closed resolved

Reason: PR #6237 was merged into main as commit 0f576502e, completing the SNAPCRAFT-1332 refactor. The author noted that the remaining kernel-plugins spread failure was pre-existing.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Migrates the _kernel_build module from snapcraft_legacy and makes it compliant with modern linting and type-checking. Review by commit if you want to see my manual changes. (SNAPCRAFT-1332) --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #6237 in commit 0f576502e, migrating kernel_build from snapcraft_legacy to modern linting and type-checking standards.
stealth/space-bunny-alpha — closed resolved Merged #6237 in commit 0f576502e, migrating kernel_build from snapcraft_legacy to modern linting and type-checking standards.
stealth/space-bunny-alpha — closed resolved Merged PR #6237 as commit 0f576502e, migrating kernel_build from snapcraft_legacy to comply with modern linting and type-checking.
stealth/space-bunny-alpha — closed resolved Merged PR #6237 via commit 0f576502e, migrating kernel_build from snapcraft_legacy to modern linting and type-checking standards. Reviewers confirmed the kernel-plugins failure predated the refactor.
qwen/qwen3.6-35b-a3b — — Merged refactor migrating kernel_build from snapcraft_legacy to modern linting and type-checking standards. Approved by reviewers. CI failures were pre-existing and unrelated. The module is slated for deletion in a future feature branch.
qwen3.6-35b-a3b-mtp-q6 — — Squash merged a refactor migrating _kernel_build from snapcraft_legacy to meet modern linting and type-checking. Manual spread tests confirmed a clean refactor. The module will be deleted in the feature/kernel-initrd-plugin branch.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#6228 refactor: migrate sign-build command snapcraft merged Merged PR #6228 as commit 2904d0be2, migrating the sign-build command from Snapcraft's legacy codebase as part of SNAPCRAFT-1320.
75%
#1618019 builds of "type: kernel" add obsolete options to snap.yaml snapcraft (launchpad) closed Fixed upstream by merged PR snapcore/snapcraft#768 (commit 71b81ad44), which dropped the obsolete top-level kernel snap.yaml entries (dtbs, firmware, initrd, kernel, modules), so Launchpad kernel snap builds no longer fail store auto-upload.
71%