refactor: migrate sign-build command
Metadata
Current evaluation
Merged refactoring PR that migrates the sign-build command out of the legacy codebase (SNAPCRAFT-1320). Approved by two reviewers and integrated after a lint failure was resolved in a separate PR.
Suggested action: —
No scores available.
Issue body
Migrates the `sign-build` command out of the legacy codebase.
SNAPCRAFT-1320
---
- [ ] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md).
- [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [ ] I've successfully run `make lint && make test`.
- [ ] I've added or updated any relevant documentation.
- [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.
- [ ] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged refactoring PR that migrates the sign-build command out of the legacy codebase (SNAPCRAFT-1320). Approved by two reviewers and integrated after a lint failure was resolved in a separate PR. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Migrated the sign-build command from the legacy codebase. Lint failures were resolved in follow-up PR #6229, and the refactoring was successfully merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Migrated the sign-build command from the legacy codebase. A lint failure was resolved in PR #6229 before the changes were merged. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #6145 refactor: migrate gated command | snapcraft | merged | Merged the refactoring that migrates the gated command from snapcraft_legacy. Approved by two reviewers and passed most CI checks. Resolves SNAPCRAFT-1314. | |
| #831 'sign-build' implementation. | snapcraft | merged | Merged the snapcraft sign-build command for generating, signing, and pushing assertions. Supersedes PR 795. Lint errors were fixed and design concerns regarding future release integration were resolved with reviewer approval. | |
| #6237 refactor: migrate kernel_build | snapcraft | merged | Merged refactor migrating kernel_build from snapcraft_legacy to modern linting and type-checking standards. Approved by reviewers. CI failures were pre-existing and unrelated. The module is slated for deletion in a future feature branch. | |
| #6218 refactor: migrate promote command | snapcraft | merged | Migrated the promote command from snapcraft_legacy to the main codebase as a near-verbatim port to preserve complex legacy behaviors. Approved by two reviewers and merged after passing most CI checks, despite one store integration test failure. | |
| #5007 refactor(application): commands, pre-run validation | snapcraft | merged | Merged after approval and CI. Refactored command handling and pre-run validation using craft-cli groups. Improved error formatting, targeted SNAPCRAFT_REMOTE_BUILD_STRATEGY validation, and fixed core20/core24 compatibility. Resolves #4911 and #5008. | |
| #5826 fix: parse a snap file for the sign-build command | snapcraft | merged | Merged fix aligning legacy and modern Craft CLI argument parsing for the sign-build command, resolving mismatch errors. Also removed redundant --local help text. Addresses #5618. Approved and passed CI. | |
| #6144 refactor: migrate keys | snapcraft | merged | Squash merged the migration of the keys command from snapcraft_legacy. Approved by two reviewers, the change modified 12 files with a net reduction of 157 lines. Resolves SNAPCRAFT-1315. | |
| #6141 refactor: migrate create-key command | snapcraft | merged | Merged after approval. The create-key command was successfully migrated from snapcraft_legacy. Integration test failures were dismissed as unrelated by the author, and the PR was squash merged. | |
| #1520 refactor: remove old "init" command implementation | charmcraft | merged | Merged a refactoring PR removing the old "init" command after the craft-application transition. Approved by two reviewers with passing CI, the change modified four files, adding one line and deleting 248. |