← Back to issue list

refactor: migrate sign-build command

View original Github issue

Metadata

Project
snapcraft
Number
#6228
Type
pull request
State
merged
Author
bepri
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #6228 as commit 2904d0be2, migrating the sign-build command from Snapcraft's legacy codebase as part of SNAPCRAFT-1320.

Resolution: closed resolved

Reason: PR #6228 was approved and merged into main as commit 2904d0be2, completing the sign-build command migration.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Migrates the `sign-build` command out of the legacy codebase. SNAPCRAFT-1320 --- - [ ] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #6228 as commit 2904d0be2, migrating the sign-build command from Snapcraft's legacy codebase as part of SNAPCRAFT-1320.
stealth/space-bunny-alpha — closed resolved Merged PR #6228 (commit 2904d0be2), migrating sign-build out of Snapcraft's legacy codebase.
qwen/qwen3.6-35b-a3b — — Merged refactoring PR that migrates the sign-build command out of the legacy codebase (SNAPCRAFT-1320). Approved by two reviewers and integrated after a lint failure was resolved in a separate PR.
qwen3.6-35b-a3b-mtp-q6 — — Migrated the sign-build command from the legacy codebase. Lint failures were resolved in follow-up PR #6229, and the refactoring was successfully merged.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#6145 refactor: migrate gated command snapcraft merged Merged PR #6145 as commit 21091b932, migrating the gated command from snapcraft_legacy and resolving SNAPCRAFT-1314.
77%
#831 'sign-build' implementation. snapcraft merged Merged as commit ded7281c9, adding sign-build to generate, sign, and optionally push snap-build assertions; superseded PR #795.
77%
#6237 refactor: migrate kernel_build snapcraft merged Merged #6237 in commit 0f576502e, migrating kernel_build from snapcraft_legacy to modern linting and type-checking standards.
75%
#6144 refactor: migrate keys snapcraft merged PR #6144 merged the migration of the keys command out of snapcraft_legacy, completing SNAPCRAFT-1315 in commit 30c9fcd19.
73%
#5239 refactor: use craft-application's remote-build snapcraft merged Merged PR #5239 as f31d99498, replacing Snapcraft’s legacy remote-build path with craft-application’s command for CRAFT-4044.
73%
#2283 snapcraft snap: refactor override-build into a script snapcraft merged PR #2283 merged as commit f9592939a, moving the Snapcraft snap's override-build logic into a script to reduce snapcraft.yaml duplication ahead of self-vendoring.
73%
#5826 fix: parse a snap file for the sign-build command snapcraft merged Merged PR #5826 (commit bf00a385e) fixed sign-build snap-file parsing and removed duplicate --local help text; it fixes #5618.
73%
#1628679 Implement 'sign-build' command snapcraft (launchpad) closed Implemented via snapcore/snapcraft PR #831 (commit ded7281c9), which added `snapcraft sign-build <snap>` to generate, sign and optionally push snap-build assertions. Superseded earlier WIP PR #795; still present in snapcraft/commands/keys.py.
71%
#5618 sign-build --local just doesn't work snapcraft closed Fixed by merged PR #5826 (commit bf00a385e, "fix: parse a snap file for the sign-build command"), which declared the missing snap-file argument in the legacy sign-build command; tracked internally as SNAPCRAFT-1180.
71%
#5359 docs: migrate build environment reference page snapcraft merged Merged PR #5359 via commit 1678a1ea9, migrating the legacy build-options page's build environment reference into Snapcraft's in-repo documentation.
71%