← Back to issue list

Snapcraft upload+release not capturing review error

View original Github issue

Metadata

Project
snapcraft
Number
#6299
Type
issue
State
open
Author
farshidtz
Labels
Created
Updated
Closed

Current evaluation

snapcraft upload --release reports success despite store review failures due to incorrect status handling in notify_upload. Issue is unlabelled and inactive for 74 days.

Suggested action: needs triage

Reason: The issue reports a bug where `snapcraft upload --release` falsely reports success when store reviews fail. Code inspection of `snapcraft/store/client.py` suggests the `notify_upload` method incorrectly treats statuses like 'error while processing' as successful if the `errors` field is empty, leading to false positive output. The issue lacks labels and maintainer engagement, requiring triage to verify the API behavior and implement a fix.

Impact: 70 Quick Win: 42.0 Staleness: 65 Complexity: 40 Confidence: 80 Support Request: 10

Issue body

### Check existing issues - [x] I've verified that this bug isn't described by any existing issues. ### Bug description The `snapcraft upload --release` seldom reports a successful release even when the store/security review has failed and blocked that release. ### Steps to reproduce This happens rarely. For example: ``` Status: processing Status: processing Status: error while processing Revision 58 created for 'gemma4' and released to 'latest/edge' ``` The review on the store has failed: ``` Thu 30 April 2026 #58 Rejected. Automated components review found issues: ['Unexpected Error (task-id: b10cb1c2-05c2-4700-822c-b673c9862da3)'] Thu 30 April 2026 #58 request_components_review. Automated review found no issues. Thu 30 April 2026 #58 Updated version by Farshid Tavakolizadeh. Thu 30 April 2026 #58 New version uploaded, v e4b+d10c8b8 (58) ``` The revision can be seen, but it hasn't been released: ``` $ snapcraft revisions gemma4 Rev. Uploaded Arches Version Channels 59 2026-04-30T10:18:23Z arm64 e4b+8351619 - 58 2026-04-30T09:33:45Z amd64 e4b+d10c8b8 - 57 2026-04-29T20:53:42Z amd64 e4b+af8779f latest/edge* 56 2026-04-29T20:53:01Z arm64 e4b+927d4e9 latest/edge/pr-8* ``` Snap download can't find the revision: ``` $ sudo snap download gemma4 --revision=58 Fetching snap "gemma4" error: cannot download snap "gemma4": no snap revision available as specified ``` ### Environment Occured with Snapcraft 8 and 9. ### snapcraft.yaml ```yaml ``` ### Log output ```shell # Additional example $ snapcraft upload gemma4_2.0.0-beta.2+9d70c71_amd64.snap --component llamacpp-cuda=gemma4+llamacpp-cuda.comp --component llamacpp-onemkl=gemma4+llamacpp-onemkl.comp --component llamacpp-rocm=gemma4+llamacpp-rocm.comp --component llamacpp=gemma4+llamacpp.comp --component mmproj-26b-bf16-gguf=gemma4+mmproj-26b-bf16-gguf.comp --component mmproj-e2b-bf16-gguf=gemma4+mmproj-e2b-bf16-gguf.comp --component mmproj-e4b-q8-0-gguf=gemma4+mmproj-e4b-q8-0-gguf.comp --component model-26b-a4b-q4-k-m-1-of-4=gemma4+model-26b-a4b-q4-k-m-1-of-4.comp --component model-26b-a4b-q4-k-m-2-of-4=gemma4+model-26b-a4b-q4-k-m-2-of-4.comp --component model-26b-a4b-q4-k-m-3-of-4=gemma4+model-26b-a4b-q4-k-m-3-of-4.comp --component model-26b-a4b-q4-k-m-4-of-4=gemma4+model-26b-a4b-q4-k-m-4-of-4.comp --component model-e2b-q4-k-m-gguf=gemma4+model-e2b-q4-k-m-gguf.comp --component model-e4b-it-int4-ov-1-of-2=gemma4+model-e4b-it-int4-ov-1-of-2.comp --component model-e4b-it-int4-ov-2-of-2=gemma4+model-e4b-it-int4-ov-2-of-2.comp --component model-e4b-q4-k-m-gguf=gemma4+model-e4b-q4-k-m-gguf.comp --component openvino-model-server=gemma4+openvino-model-server.comp --release=latest/edge/pr-64 Unsquashing snap file 'gemma4_2.0.0-beta.2+9d70c71_amd64.snap'. Uploading... (--->) ... Uploading... (<---) Status: processing ... Status: processing Status: error while processing Revision 223 created for 'gemma4' and released to 'latest/edge/pr-64' # Automated review for version 2.0.0-beta.2+9d70c71: passed Fri 19 June 2026 #223 Rejected. Automated components review found issues: ['error creating resource revisions'] Fri 19 June 2026 #223 request_components_review. Automated review found no issues. Fri 19 June 2026 #223 Updated version by Farshid Tavakolizadeh. Fri 19 June 2026 #223 New version uploaded, v 2.0.0-beta.2+9d70c71 (223) ```

Evaluation history

Date Model Scores Action Summary
qwen3.6-35b-a3b-mtp-q6
Impact: 70
Quick Win: 42.0
Staleness: 65
Complexity: 40
Confidence: 80
Support Request: 10
needs triage snapcraft upload --release reports success despite store review failures due to incorrect status handling in notify_upload. Issue is unlabelled and inactive for 74 days.
qwen/qwen3.6-35b-a3b
Staleness: 45
Complexity: 45
Confidence: 90
Support Request: 10
needs triage Snapcraft CLI reports successful release after upload even when Snap Store automated review fails. Unlabeled and awaiting maintainer triage.
qwen3.6-35b-a3b-mtp-q6
Staleness: 45
Complexity: 35
Confidence: 90
Support Request: 10
needs triage snapcraft upload --release reports success despite Snap Store automated review failures blocking the release. Unlabelled, awaiting maintainer triage.
qwen3.6-35b-a3b-mtp-q6
Staleness: 5
Complexity: 45
Confidence: 85
Support Request: 10
needs triage snapcraft upload --release reports success despite store review failures, leaving revisions unreleased. Reported with reproduction steps and logs; awaiting maintainer assessment.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#6310 fix(store): raise error when upload processing status is 'error' snapcraft open Fixes snapcraft upload --release silently reporting success when store review fails by checking status code 'error' in notify_upload. Waiting for maintainer review for 72 days.
81%
#1627865 Snapcraft errors when releasing a snap snapcraft (launchpad) open Snapcraft push --release hangs in 'Processing...' after a JSONDecodeError from the store status endpoint (storeapi._update_status). No maintainer activity in ~10 years; the storeapi module no longer exists in the codebase.
71%
#1967722 snapcraft upload --release fails for registered snap snapcraft (launchpad) closed Abandoned and closed without resolution. The reported snapcraft upload --release failure claiming an unregistered snap despite store registration remains unresolved.
71%