← Back to issue list

feat: resolve icon names from the hicolor theme

View original Github issue

Metadata

Project
snapcraft
Number
#6329
Type
pull request
State
merged
Author
soumyaDghosh
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #6329 resolves desktop-file icon names through the hicolor theme by reusing AppStream metadata path-normalization logic.

Resolution: closed resolved

Reason: PR #6329 was merged after approval by three reviewers. Its change normalizes named desktop-file icons and resolves them through the hicolor theme.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Currently snapcraft ignores if an icon is provided as a name in the desktop file, snapcraft doesn't try to normalize the path. This patch fixes that by reusing the logic from appstream metadata. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [x] I've added or updated any relevant documentation. - [x] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [x] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #6329 resolves desktop-file icon names through the hicolor theme by reusing AppStream metadata path-normalization logic.
stealth/space-bunny-alpha — closed resolved Merged PR #6329 resolves desktop-file icon names through the hicolor theme by reusing AppStream metadata path-normalization logic (commit 6fd86ea93).
stealth/space-bunny-alpha — closed resolved Merged PR #6329 resolves desktop-file icon names through the hicolor theme by reusing AppStream metadata path-normalization logic.
qwen/qwen3.6-35b-a3b — — Merged external contributor soumyaDghosh's fix for snapcraft to resolve desktop file icon names from the hicolor theme. Reuses appstream metadata logic for path normalization. Approved by three reviewers and integrated.
qwen3.6-35b-a3b-mtp-q6
Staleness: 5
Complexity: 40
Confidence: 90
needs review Adds logic to resolve desktop file icon names from the hicolor theme by reusing appstream metadata parsing. Currently awaiting maintainer review and CI validation.

Update history

Date Change
updated

Related issues

Issue Project State Summary Similarity
#2512 many: better handling of appstream icons snapcraft merged Merged in PR #2512 (commit 9e8601b80): AppStream stock icons are resolved at packaging time, with desktop-file icons used as fallback.
71%