many: better handling of appstream icons
Metadata
Current evaluation
Merged changes improve AppStream icon handling by resolving stock icons at packaging time and falling back to desktop file definitions. Reviewers noted spec compliance concerns with theme parsing, but the PR was approved and merged.
Suggested action: —
No scores available.
Issue body
Appstream icons can be specified as a full path ("local") or just the
application name to be searched in the standard locations ("stock").
The system search for stock icons doesn't include directories that are
part of snap packages, so support stock icons by resolving the path
at packaging time. If icons are not specified in the AppStream file,
use the desktop file definition instead.
LP: #1814898
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged changes improve AppStream icon handling by resolving stock icons at packaging time and falling back to desktop file definitions. Reviewers noted spec compliance concerns with theme parsing, but the PR was approved and merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged improvements to AppStream icon handling that resolve stock icons at packaging time and fall back to desktop file definitions. Reviewers noted theme spec compliance and SVG preference concerns, but the changes were accepted and integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Improved AppStream icon handling by resolving stock icons at packaging time and falling back to desktop files. Reviewers flagged spec compliance concerns, but the changes were accepted and integrated. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3241 snap packaging: fetch remote icons configured via appstream | snapcraft | merged | Merged. Implements remote icon fetching for appstream-configured http(s) URLs, consolidates icon handling into _finalize_icon(), updates schema validation, and adds spread tests. Approved by reviewer and passed CI. | |
| #1853 extractors: support appstream icon and desktop | snapcraft | merged | Merged PR adding AppStream icon and desktop file support to extractors. Approved by two reviewers and passed CI after fixing test failures caused by string casting side effects. Closes issue #1828. |