many: better handling of appstream icons
Metadata
Current evaluation
Merged in PR #2512 (commit 9e8601b80): AppStream stock icons are resolved at packaging time, with desktop-file icons used as fallback.
Resolution: closed resolved
Reason: PR #2512 was merged as commit 9e8601b80, resolving AppStream icon handling by supporting stock-icon resolution during packaging and falling back to desktop-file icon definitions.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Appstream icons can be specified as a full path ("local") or just the
application name to be searched in the standard locations ("stock").
The system search for stock icons doesn't include directories that are
part of snap packages, so support stock icons by resolving the path
at packaging time. If icons are not specified in the AppStream file,
use the desktop file definition instead.
LP: #1814898
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in PR #2512 (commit 9e8601b80): AppStream stock icons are resolved at packaging time, with desktop-file icons used as fallback. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2512 (commit 9e8601b80): AppStream stock icons are now resolved during packaging, with desktop-file icons used as fallback. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged changes improve AppStream icon handling by resolving stock icons at packaging time and falling back to desktop file definitions. Reviewers noted spec compliance concerns with theme parsing, but the PR was approved and merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged improvements to AppStream icon handling that resolve stock icons at packaging time and fall back to desktop file definitions. Reviewers noted theme spec compliance and SVG preference concerns, but the changes were accepted and integrated. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #3380 snap packaging: fix broken path check when copying local icon | snapcraft | merged | Merged PR #3380 fixed copying local icons referenced by desktop files and added spread-test coverage for the previously missed AppStream path. | |
| #3241 snap packaging: fetch remote icons configured via appstream | snapcraft | merged | Merged PR #3241 (commit 5158fe2fd, 'meta: fetch remote icons configured via appstream') by cjp256: consolidated icon handling into _finalize_icon() and allowed http(s) URLs in the icon schema. | |
| #6329 feat: resolve icon names from the hicolor theme | snapcraft | merged | Merged PR #6329 resolves desktop-file icon names through the hicolor theme by reusing AppStream metadata path-normalization logic. | |
| #1828 Support desktop and icon in appstream handler | snapcraft | closed | AppStream metadata gained icon and desktop support in merged PR canonical/snapcraft#1853 (commit ce3209468), closing the feature request. |