fix(desktop-file): verify theme icons before rewriting icon
Metadata
Current evaluation
PR to fix desktop file icon theme warning; diff targets outdated code and doesn't address the described bug
Suggested action: close not mergeable
Reason: The PR's diff targets code that no longer exists — the strip operations were refactored into `_normalize_icon_path()` in commit f702705c6 (PR #6385). Additionally, the diff only refactors string operations and doesn't address the actual bug described in the body (checking `icon` instead of `icon_path` after theme resolution). The underlying issue (#6364) remains open.
Issue body
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen3.6-35b-a3b-mtp-q6 |
Impact:
30
Quick Win:
25.5
Staleness:
75
Complexity:
15
Confidence:
70
|
close not mergeable | PR to fix desktop file icon theme warning; diff targets outdated code and doesn't address the described bug | |
| qwen/qwen3.6-35b-a3b |
Staleness:
5
Complexity:
10
Confidence:
90
|
needs review | Fixes a bug where theme-resolved icon paths were written to desktop files without existence checks, causing spurious warnings. Currently awaiting maintainer review with CI mostly passing. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
5
Complexity:
5
Confidence:
85
|
needs review | Fixes a bug where theme-resolved icon paths were written to desktop files without existence checks, causing spurious warnings. Currently pending maintainer review with CI passing except for a one-time CLA check. |
Update history
| Date | Change |
|---|---|
| updated | |
| created |
Related work
-
Related To:
canonical/snapcraft#6364
(confidence 95%)
The PR claims to fix this issue, but the diff is outdated and doesn't address the root cause. Issue remains open.
-
Blocked By:
canonical/snapcraft#6385
(confidence 85%)
PR #6385 refactored desktop file handling, making this PR's diff obsolete.
Related issues
No related issues found above the similarity threshold.