← Back to issue list

feat: mediate desktop, icon, and manifest files

View original Github issue

Metadata

Project
snapcraft
Number
#6385
Type
pull request
State
merged
Author
cmatsuoka
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #6385 as f702705c6, adding mediation for desktop, icon, manifest.yaml, and snapcraft.yaml assets.

Resolution: closed resolved

Reason: The approved PR was merged into main at commit f702705c6. It resolves #6359 by using craft-application 7.1.0 mediation so asset changes are correctly packaged.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Implement metadata mediation for desktop and icon assets, and also for manifest.yaml and snapcraft.yaml when `SNAPCRAFT_BUILD_INFO` is defined. --- SNAPCRAFT-1375 - [ ] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [ ] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #6385 as f702705c6, adding mediation for desktop, icon, manifest.yaml, and snapcraft.yaml assets.
stealth/space-bunny-alpha — closed resolved Merged PR canonical/snapcraft#6385 as commit f702705c6, adding metadata mediation for desktop, icon, manifest.yaml, and snapcraft.yaml assets.
qwen/qwen3.6-35b-a3b — — Implemented metadata mediation for desktop, icon, and manifest files when SNAPCRAFT_BUILD_INFO is defined. Merged following two approvals, resolving SNAPCRAFT-1375.
qwen/qwen3.6-35b-a3b — — Merged after maintainer approval. Implements metadata mediation for desktop, icon, and manifest files when SNAPCRAFT_BUILD_INFO is defined. One integration test failed but did not block the merge.
qwen/qwen3.6-35b-a3b — — Merged after two approvals. Adds metadata mediation for desktop, icon, and manifest files when SNAPCRAFT_BUILD_INFO is defined. 574 additions and 72 deletions across 12 files. One failing test did not block the merge.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 40
Confidence: 85
needs review Implements metadata mediation for desktop, icon, and manifest files. Approved by 2 reviewers with 0 unresolved comments. Most CI checks pass, though one integration test fails and several jobs are pending.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 90
needs review Implements metadata mediation for desktop, icon, and manifest files. Approved by two reviewers with one unresolved comment. CI is passing with several checks pending.
qwen/qwen3.6-35b-a3b
Staleness: 10
Complexity: 45
Confidence: 85
needs review Implements metadata mediation for desktop, icon, and manifest files. Approved by two reviewers with two unresolved comments. CI checks are passing with several pending.
qwen/qwen3.6-35b-a3b
Staleness: 15
Complexity: 45
Confidence: 85
needs review Implements metadata mediation for desktop, icon, and manifest files. Approved by two reviewers with two unresolved comments. Currently has three failing CI checks and several pending integration tests.
qwen/qwen3.6-35b-a3b
Staleness: 10
Complexity: 45
Confidence: 85
needs review Implements metadata mediation for desktop/icon assets and manifest files. Currently approved by two reviewers but has three unresolved comments and two failing integration tests.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 85
needs review Implements metadata mediation for desktop, icon, and manifest files when SNAPCRAFT_BUILD_INFO is defined. Approved by 2 reviewers with 3 unresolved comments and 2 failing integration tests.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 65
Confidence: 85
needs review Implements metadata mediation for desktop, icon, and manifest files. Approved by one reviewer with two unresolved comments. CI passes most checks but fails two integration tests.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 90
needs review Implements metadata mediation for desktop, icon, and manifest files when SNAPCRAFT_BUILD_INFO is defined. Currently pending maintainer review with 1 unresolved comment and 2 failing integration tests.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 85
needs review Implements metadata mediation for desktop, icon, and manifest files when SNAPCRAFT_BUILD_INFO is defined. Fresh PR with mostly passing CI, awaiting initial review.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 85
needs review Implements metadata mediation for desktop, icon, and manifest files. Currently awaiting maintainer review with zero comments. CI shows two failing integration tests alongside many passing checks.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 90
needs review Implements metadata mediation for desktop, icon, and manifest files. Currently awaiting maintainer review with CI checks passing or pending integration tests.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 90
needs review Implements metadata mediation for desktop, icon, and manifest files when SNAPCRAFT_BUILD_INFO is defined. Currently awaiting maintainer review with CI checks passing and integration tests running.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 35
Confidence: 90
needs review Implements metadata mediation for desktop, icon, and manifest files when SNAPCRAFT_BUILD_INFO is defined. Currently awaiting maintainer review with CI checks running.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 35
Confidence: 90
needs review Implements metadata mediation for desktop, icon, and manifest files when SNAPCRAFT_BUILD_INFO is defined. Currently awaiting maintainer review with CI checks pending.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 35
Confidence: 85
needs review Implements metadata mediation for desktop, icon, and manifest files when SNAPCRAFT_BUILD_INFO is defined. Currently awaiting maintainer review with CI checks still running.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 65
needs review Implements metadata mediation for desktop, icon, and manifest files. Currently pending maintainer review with several failing integration tests and lint checks.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 80
needs review Implements metadata mediation for desktop, icon, and manifest files. Currently pending review with one unresolved comment and several failing integration and lint tests.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 90
needs review Implements metadata mediation for desktop, icon, and manifest files. Currently pending maintainer review with 2 unresolved comments and 2 failing CI checks.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 85
needs review Implements metadata mediation for desktop, icon, and manifest files. Currently pending maintainer review with CI failing on lint checks and several jobs still running.

Update history

Date Change
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
created

Related work

  • Related To: canonical/snapcraft#6359 (confidence 99%)

    Tracking issue for mediating desktop and icon asset creation, resolved by this merged implementation.

Related issues

Issue Project State Summary Similarity
#6359 Mediate creation of desktop and icon files snapcraft closed Desktop, icon, and manifest file creation now uses craft-application 7.1.0 mediation, enabling repacking after asset changes; merged in PR #6385 as f702705c6.
75%
#6379 feat: mediate creation of hooks and gui assets snapcraft merged Merged #6379, adding Craft Application metadata mediation when copying hooks and GUI assets into snap artifacts.
72%