← Back to issue list

feat: mediate creation of hooks and gui assets

View original Github issue

Metadata

Project
snapcraft
Number
#6379
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged pull request implementing the Craft Application metadata mediation API for copying hooks and GUI assets to snap artifacts. Approved by two reviewers and passed most CI checks, despite one failing store test.

Suggested action:

No scores available.

Issue body

Implement the Craft Application metadata mediation API when copying hooks and GUI assets to the snap artifact. --- CRAFT-1374 - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged pull request implementing the Craft Application metadata mediation API for copying hooks and GUI assets to snap artifacts. Approved by two reviewers and passed most CI checks, despite one failing store test.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 85
needs review Implements Craft Application metadata mediation API for copying hooks and GUI assets to snap artifacts. Approved by 2 reviewers with 1 unresolved comment. CI mostly passes except one integration test.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 85
needs review Implements Craft Application metadata mediation API for copying hooks and GUI assets to snap artifacts. Approved by one reviewer, CI mostly passing except one failing integration test.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 85
needs review Implements Craft Application metadata mediation API for copying hooks and GUI assets to snap artifacts. Currently pending maintainer review with one failing integration test.
qwen/qwen3.6-35b-a3b
Staleness: 0
Complexity: 45
Confidence: 90
needs review Implements Craft Application metadata mediation API for copying hooks and GUI assets to snap artifacts. Currently pending CI checks and maintainer review.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 90
needs review Implements metadata mediation API for copying hooks and GUI assets to snap artifacts. Currently awaiting maintainer review with several CI checks still running.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 90
needs review Implements Craft Application metadata mediation API for copying hooks and GUI assets to snap artifacts. Currently awaiting maintainer review with CI failing on lint checks.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 90
needs review Implements metadata mediation API for copying hooks and GUI assets to snap artifacts. Currently awaiting maintainer review, with one lint failure and several integration tests pending.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 90
needs review Implements Craft Application metadata mediation API for copying hooks and GUI assets to snap artifacts. Currently awaiting maintainer review with one failing lint check and pending integration tests.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 90
needs review Implements Craft Application metadata mediation API for copying hooks and GUI assets to snap artifacts. Currently awaiting maintainer review with a failing lint check and pending integration tests.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 90
needs review Implements Craft Application metadata mediation API for copying hooks and GUI assets to snap artifacts. Currently pending maintainer review with zero comments, CI failing on lint/files, and several integration tests pending.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 90
needs review Implements metadata mediation API for copying hooks and GUI assets to snap artifacts. Currently awaiting maintainer review with zero comments. CI shows one lint failure and several pending integration tests.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 90
needs review Implements Craft Application metadata mediation API for copying hooks and GUI assets to snap artifacts. Currently pending maintainer review with failing lint and test checks.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 85
needs review Implements Craft Application metadata mediation API for copying hooks and GUI assets to snap artifacts. Currently pending maintainer review with 0 comments. Several integration tests and a lint check are failing.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 85
needs review Implements Craft Application metadata mediation API for copying hooks and GUI assets to snap artifacts. Currently pending maintainer review with most CI checks passing, though some integration tests are failing or pending.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 90
needs review Implements metadata mediation API for copying hooks and icon assets to snap artifacts. Currently pending maintainer review with CI checks still running.
qwen/qwen3.6-35b-a3b
Staleness: 10
Complexity: 45
Confidence: 90
needs review Implements metadata mediation API for copying hooks and icon assets to snap artifacts. Currently awaiting maintainer review and pending CI checks.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 90
needs review Implements Craft Application metadata mediation API for copying hooks and icon assets to snap artifacts. Currently pending maintainer review with one failing lint check and several pending CI jobs.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 85
needs review Implements metadata mediation API for copying hooks and icon assets to snap artifacts. Currently pending initial maintainer review with unresolved comments and several failing CI checks.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 85
needs review Implements Craft Application metadata mediation API for copying hooks and icon assets to snap artifacts. Currently under initial review with failing CI checks and unresolved comments.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 45
Confidence: 90
needs review Implements Craft Application metadata mediation API for copying hooks and icon assets to snap artifacts. Currently pending maintainer review with 0 comments, most CI checks passing, two failing.

Update history

Date Change
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
created

Related issues

Issue Project State Summary Similarity
#6358 Mediate creation of snap hook and gui assets. snapcraft open Feature request to mediate snap hook and gui assets creation using craft-application 7.1.0 mediation API. Appears implemented in PR #6379.
79%
#2874 feat: mediate creation of metadata.yaml charmcraft merged Merged after two approvals. Implements craft-application's package service API to mediate metadata.yaml creation. Integrated into main despite some failing CI tests on specific Ubuntu versions, altering three files.
76%
#6355 feat: mediate creation of component.yaml snapcraft merged Merged after two approvals. Implements craft-application metadata mediation to generate component.yaml for each component artifact, resolving #6360 and CRAFT-1376. CI passed and conflicts were resolved prior to merge.
74%
#2877 feat: implement metadata mediation for manifest.yaml charmcraft open Implements metadata mediation for manifest.yaml using craft-application packaging API. Has 2 approvals but 3 unresolved review comments and some failing CI tests.
73%
#6385 feat: mediate desktop, icon, and manifest files snapcraft merged Implemented metadata mediation for desktop, icon, and manifest files when SNAPCRAFT_BUILD_INFO is defined. Merged following two approvals, resolving SNAPCRAFT-1375.
72%
#6349 feat: implement metadata mediation for snap.yaml snapcraft merged Merged. Implements metadata mediation for snap.yaml via a new packaging API to skip repacking when contents match. Other files handled separately. Approved by two reviewers and passed CI.
71%