fix(validation-sets): sort sequences numerically
Metadata
Current evaluation
PR #6449 proposed numeric validation-set sequence sorting for #6324 but was closed unmerged; no merge commit was created and #6324 remains open.
Resolution: closed stale
Reason: The PR was closed unmerged after the author requested review, with no reviewers assigned or maintainer resolution. The underlying bug in #6324 remains open.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The store returns validation sets with their sequences sorted as strings, so `snapcraft validation-sets --sequence all` listed `1, 10, 11, ..., 2, 20`.
Validation sets are now sorted by account ID, name, and then numerically by sequence before they're shown, in both table and JSON output. Sorting by name first keeps each validation set's sequences together when all validation sets are listed.
Fixes #6324
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [x] I've successfully run `make lint && make test`.
- [ ] I've added or updated any relevant documentation.
- [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.
- [ ] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed stale | PR #6449 proposed numeric validation-set sequence sorting for #6324 but was closed unmerged; no merge commit was created and #6324 remains open. | |
| stealth/space-bunny-alpha | — | closed stale | Numeric validation-set sorting was not merged: PR #6449 closed unmerged without review; bug #6324 remains open. | |
| stealth/space-bunny-alpha | — | closed stale | PR #6449 (numeric sorting of validation-set sequences) was closed unmerged after 3 days with no reviewer and no merge commit; superseded attempt #6339 also closed. Issue #6324 remains open. | |
| qwen/qwen3.8-27b | — | closed stale | PR closed unmerged after author requested review; no reviewers assigned and no merge commit found. The underlying bug (issue #6324, lexicographic sequence sorting in validation-sets) remains open. | |
| stealth/space-bunny-alpha |
Impact:
40
Quick Win:
26
Complexity:
20
Confidence:
93
Actionability:
80
|
needs review | Numerically sorts validation-set results by account ID, name, then sequence for table and JSON output. The revised PR is pending maintainer review, with no unresolved comments or failing checks. |
Update history
| Date | Change |
|---|---|
| closed | |
| updated | |
| created |
Related work
-
Related To:
canonical/snapcraft#6324
(confidence 100%)
PR #6449 states that it fixes this still-open issue.
-
Related To:
canonical/snapcraft#6339
(confidence 98%)
Earlier numeric-sorting PR, also closed unmerged; #6449 revised its ordering to keep sequences grouped by validation set.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #6339 fix: sort validation sets by numeric sequence | snapcraft | closed | PR #6339 proposed numeric sorting for validation sets but was closed unmerged after 73 days without review; its Canonical CLA check had failed. | |
| #6324 validation-sets sorts integer sequence alphabetically | snapcraft | open | `snapcraft validation-sets --sequence all` lists sequences lexicographically (1, 10, 11, 2...) instead of numerically. Clear reproducer; two fix PRs (#6339, #6449) were opened and both closed unmerged, so the bug persists. | |
| #6423 fix(validation-sets): don't validate new sets | snapcraft | closed | PR #6423 (SNAPCRAFT-1379) fixed edit-validation-sets rejecting brand-new validation sets at sequence 1; approved with no unresolved comments and landed as commit e7b47adb7, stacking on merged PR #6420. |