← Back to issue list

fix(validation-sets): don't validate new sets

View original Github issue

Metadata

Project
snapcraft
Number
#6423
Type
pull request
State
closed
Author
mr-cal
Labels
PR: Rebase
Created
Updated
Closed

Current evaluation

PR #6423 (SNAPCRAFT-1379) fixed edit-validation-sets rejecting brand-new validation sets at sequence 1; approved with no unresolved comments and landed as commit e7b47adb7, stacking on merged PR #6420.

Resolution: closed resolved

Reason: The PR was approved by three reviewers with zero unresolved comments and merged, landing as commit e7b47adb7. The lone failing check (lint / files) and rebuild/publish checks were declared unrelated by the author, and the only remaining comments were rebase/force-push housekeeping.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Fixes a bug where new validation sets with sequence 1 couldn't be created. Builds on top of #6420 Fixes #6412 (SNAPCRAFT-1379) --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [x] I've added or updated any relevant documentation. - [x] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [x] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #6423 (SNAPCRAFT-1379) fixed edit-validation-sets rejecting brand-new validation sets at sequence 1; approved with no unresolved comments and landed as commit e7b47adb7, stacking on merged PR #6420.
stealth/space-bunny-alpha — closed resolved Landed as commit e7b47adb7, allowing new validation sets at sequence 1 while building on PR #6420.
qwen/qwen3.6-35b-a3b
Impact: 50
Quick Win: 35
Staleness: 5
Complexity: 30
Confidence: 85
needs review Fixes bug preventing creation of new validation sets at sequence 1. Builds on merged #6420, fixes open #6412. Fresh PR from maintainer with passing CI, awaiting review.
qwen/qwen3.6-35b-a3b
Impact: 55
Quick Win: 36
Staleness: 0
Complexity: 35
Confidence: 70
needs review Bug fix preventing creation of new validation sets at sequence 1. Builds on open PR #6420. CI failing on lint/files; pending maintainer review.
qwen/qwen3.6-35b-a3b
Impact: 55
Quick Win: 38
Staleness: 5
Complexity: 30
Confidence: 75
needs review Fixes bug where new validation sets with sequence 1 couldn't be created. Fresh PR by maintainer, pending review, most CI passing.

Update history

Date Change
closed
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
updated
created

Related work

  • Related To: canonical/snapcraft#6412 (confidence 95%)

    Issue this PR declares it fixes (SNAPCRAFT-1379); corpus still shows #6412 as open, so its state may not reflect the fix.

  • Likely Fixed By: canonical/snapcraft#6420 (confidence 85%)

    Explicit prerequisite PR ('Builds on top of #6420'), merged as commit 2989b5f8b restoring non-blocking same-sequence warnings; #6423 depends on it for correct behaviour.

Related issues

Issue Project State Summary Similarity
#5535 feat(validation-sets): warn when the sequence isn't incremented snapcraft merged PR #5535 by mr-cal merged (commit f012b667e): adds a SnapcraftAssertionWarning when a validation set's sequence isn't incremented, plus shared _validate_assertion infrastructure. Fixes #5367.
76%
#6412 edit-validation-sets refuses to create a new validation set at sequence 1 ("sequence number was not incremented") snapcraft open edit-validation-sets rejects creating a brand-new validation set at sequence 1 because the sequence-increment check runs even when no existing set exists; confirmed by maintainer, tracked as SNAPCRAFT-1379.
75%
#5545 fix(validation-sets): allow users to ignore sequence increment warning snapcraft merged Merged PR #5545 (cb96b3533), allowing users to ignore validation-set sequence-increment warnings and still submit assertions, fixing the overlooked scenario in #5535.
74%
#6420 fix: allow same-sequence validation set revisions snapcraft closed Merged as commit 2989b5f8b via PR #6420 (into hotfix/9.1), restoring the non-blocking sequence warning so edit-validation-sets can publish same-sequence revisions. Fixes #6413.
72%
#3939 command: update edit-validation-sets to craft-cli snapcraft merged Merged as commit 786854900: PR #3939 moved edit-validation-sets from snapcraft_legacy to snapcraft using craft-cli emit output, Path-based edits, and a dedicated validation-sets command group (CRAFT-1402).
71%
#4918 Test validation-set commands snapcraft closed Added and merged spread tests for edit-validation-sets and list-validation-sets in PR #4924 (commit 157d0a182), resolving #4918.
71%
#6413 edit-validation-sets makes it impossible to publish a new revision of an existing sequence (no override) snapcraft closed Regression where edit-validation-sets hard-blocked same-sequence revisions was fixed by merged PR #6420 (commit 2989b5f8b), restoring the non-blocking sequence warning from PR #5545 lost in the #6050 refactor.
71%
#3942 commands: allow re-editing validation sets on error snapcraft merged Merged PR #3942 (commit e615f7a27) lets users re-edit rejected validation sets and refactors validation-set generation and submission helpers.
70%
#6449 fix(validation-sets): sort sequences numerically snapcraft closed PR #6449 proposed numeric validation-set sequence sorting for #6324 but was closed unmerged; no merge commit was created and #6324 remains open.
70%