Spread tests should run review-tools on snaps
Metadata
Current evaluation
⚠️ This summary may be outdated — the issue content or evaluation prompts have changed since this evaluation was made.
Enhancement to run review-tools on all spread tests that build snaps, not just manifest tests. Triaged with a contributor interested in implementing.
Suggested action: keep open
Reason: This is a valid, triaged enhancement request with a clear scope (add review-tools checks to all snap-building spread tests). A contributor (@Deep-Axe) has already expressed interest and asked clarifying questions about implementation details. Related to snapcraft#2235 which added review-tools to manifest tests as a starting point.
Evaluated by: mr-cal-bot
Impact:
45
Quick Win:
19
Complexity:
45
Confidence:
80
Actionability:
75
Issue body
### Check existing issues
- [x] I've verified that this request isn't described by any existing issues.
### Request
Every spread test that builds a snap should pass it through [review tools](https://snapcraft.io/review-tools).
This should catch changes that previously wouldn't be identified until a snap was uploaded to the store.
### The problem it solves
Catches errors before Snapcraft is released.
As a side note, I've been considering adding review-tools as a snapcraft linting step.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b |
Impact:
45
Quick Win:
19
Complexity:
45
Confidence:
80
Actionability:
75
|
keep open | Enhancement to run review-tools on all spread tests that build snaps, not just manifest tests. Triaged with a contributor interested in implementing. | |
| minimax/minimax-m3.1-flash:free |
Impact:
55
Quick Win:
19
Complexity:
58
Confidence:
91
Actionability:
82
|
keep open | Broaden spread-test coverage so every test that builds a snap runs review-tools, catching store-review errors before release; currently only selected manifest tests do so. |
Update history
| Date | Change |
|---|---|
| updated | |
| updated | |
| updated | |
| created |
Related work
-
Related To:
snapcraft#2235
(confidence 90%)
PR that added review-tools to manifest spread tests; this issue proposes extending that pattern to all snap-building tests.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2235 tests: cover manifest generation with review-tools | snapcraft | merged | PR merged into master: manifest-generation spread tests extended to actually build a snap and run review-tools.snap-review on it (LP #1790026); the review-tools step survives today in tests/spread/_common/manifest-creation. | |
| #6408 Re-organize spread tests | snapcraft | open | Maintainer-filed, triaged enhancement to reorganize/dedupe Snapcraft's spread tests and drop low-value ones for faster, less flaky CI; no implementation plan or PR yet, tracked as SNAPCRAFT-1377. | |
| #5841 Include "build snapd snap" test in test suite | snapcraft | closed | Added spread coverage for building snapd and base snaps in merged PR #5845 (commit fb8c81e8f). | |
| #1272 tests: initial setup for the snapcraft snap tests with spread | snapcraft | merged | Merged PR #1272 as commit 545344442, adding initial Spread-based test infrastructure for the snapcraft snap. | |
| #806 Use `snapcraft test` for spread tests | craft-application | open | Maintainer dogfooding task: switch CI from invoking spread directly to `snapcraft test`. Triaged but unimplemented — .github/workflows/spread.yaml still calls `spread ${{ matrix.spread }}`; open PR #1038 attempts it with failing CI. |