tests: cover manifest generation with review-tools
Metadata
Current evaluation
PR merged into master: manifest-generation spread tests extended to actually build a snap and run review-tools.snap-review on it (LP #1790026); the review-tools step survives today in tests/spread/_common/manifest-creation.
Resolution: closed resolved
Reason: The PR itself was merged into master after approval (review status: approved, 1 reviewer), adding snap install review-tools and `review-tools.snap-review ~/manifest_0.1_*.snap` to the manifest-creation spread task. That coverage persists in the current tests/spread/_common/manifest-creation/task.yaml.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Make the integration tests for manifest generation go all the way
to creating a snap and run them through the review tools.
LP: #1790026
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR merged into master: manifest-generation spread tests extended to actually build a snap and run review-tools.snap-review on it (LP #1790026); the review-tools step survives today in tests/spread/_common/manifest-creation. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #2235 into master, extending manifest-generation integration tests to build a snap and run it through review tools. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged into master. Extends integration tests to validate manifest generation by building a snap and running it through review tools. Approved by reviewer, passed CI, and increased coverage by less than 0.01%. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to master, extending integration tests for manifest generation to build snaps and validate them with review-tools. The change resolves Launchpad bug #1790026 and increases overall code coverage by less than 0.01%. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2234 tests: cover manifest generation with review-tools | snapcraft | closed | Superseded by snapcore/snapcraft#2235, which merged the same manifest-generation integration-test coverage in commit 78c837273. | |
| #6510 Spread tests should run review-tools on snaps | snapcraft | open | Enhancement to run review-tools on all spread tests that build snaps, not just manifest tests. Triaged with a contributor interested in implementing. | |
| #1790026 add tests for manifest.yaml | snapcraft (launchpad) | closed | Manifest verification coverage was added by merged snapcore/snapcraft#2235 (commit 78c837273), building the snap and running it through click-review. |