tests: cover manifest generation with review-tools
Metadata
Current evaluation
Merged into master. Extends integration tests to validate manifest generation by building a snap and running it through review tools. Approved by reviewer, passed CI, and increased coverage by less than 0.01%.
Suggested action: —
No scores available.
Issue body
Make the integration tests for manifest generation go all the way
to creating a snap and run them through the review tools.
LP: #1790026
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged into master. Extends integration tests to validate manifest generation by building a snap and running it through review tools. Approved by reviewer, passed CI, and increased coverage by less than 0.01%. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to master, extending integration tests for manifest generation to build snaps and validate them with review-tools. The change resolves Launchpad bug #1790026 and increases overall code coverage by less than 0.01%. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes extending integration tests for manifest generation to create a snap and run it through review tools. Coverage increased by less than 0.01%, resolving Launchpad issue #1790026. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2234 tests: cover manifest generation with review-tools | snapcraft | closed | Merged into master. Added integration tests for manifest generation using review-tools and a store push test. Code coverage remained stable at 90.72%. | |
| #1542 tests: add integration tests for build snaps | snapcraft | merged | Merged integration tests for build snaps. Approved by two reviewers and passed CI. Two test scenarios omitted due to known bugs. | |
| #1849 tests: add snap not found tests | snapcraft | merged | Merged tests for missing snap scenarios. Approved by two reviewers and integrated into the codebase despite unresolved review comments and reported integration test timeouts. | |
| #1272 tests: initial setup for the snapcraft snap tests with spread | snapcraft | merged | Merged to master following single reviewer approval. Introduced initial spread test infrastructure for snapcraft across four files (+39 lines). Code coverage remained stable at 95.33%. |