← Back to issue list

rust plugin: mock downloads in unit tests

View original Github issue

Metadata

Project
snapcraft
Number
#713
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #713 (commit c8e8e3c10) mocked Cargo downloads in Rust plugin unit tests, resolving LP #1610996.

Resolution: closed resolved

Reason: The change was merged via canonical/snapcraft#713 as commit c8e8e3c10 and resolved LP #1610996.

Evaluated by: mr-cal-bot

No scores available.

Issue body

LP: #1610996 Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #713 (commit c8e8e3c10) mocked Cargo downloads in Rust plugin unit tests, resolving LP #1610996.
stealth/space-bunny-alpha — closed resolved Merged PR #713 (+7/-1) to mock downloads in Rust plugin unit tests, resolving LP #1610996.
qwen/qwen3.6-35b-a3b — — Merged a +7/-1 change to mock downloads in unit tests for the Rust plugin, resolving LP #1610996. The update received informal approval and was integrated without formal CI checks or reviewer sign-off.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes to mock network downloads in Rust plugin unit tests, improving test reliability. Approved by @come-maiz and integrated into the main branch.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1610996 rust unit test needs to mock network connections snapcraft (launchpad) closed Rust plugin unit tests mocked the rustup/Cargo downloads so tests no longer hit the network. Fixed by snapcore/snapcraft PR #713, merged as commit c8e8e3c10; maintainer closed LP #1610996 citing that PR.
75%
#2170 rust plugin: fix cargo builds and run tests snapcraft merged Merged as commit 4f80a1051, fixing Rust plugin Cargo builds, skipping tests during cross-compilation, and adding tests.
70%