rust plugin: fix cargo builds and run tests
Metadata
Current evaluation
Merged as commit 4f80a1051, fixing Rust plugin Cargo builds, skipping tests during cross-compilation, and adding tests.
Resolution: closed resolved
Reason: PR #2170 was merged as commit 4f80a1051. It fixed Cargo builds and added test coverage, including skipping Cargo tests during cross-compilation.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 4f80a1051, fixing Rust plugin Cargo builds, skipping tests during cross-compilation, and adding tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2170 fixed Cargo builds in the Rust plugin and added tests, landing as commit 4f80a1051. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 4f80a1051, fixing Cargo builds, skipping tests during cross-compilation, and adding tests for the Rust plugin. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcraft#2170 (commit 4f80a1051), fixing Cargo builds in the Rust plugin and adding tests; Codecov reported 100% diff coverage. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fixes for cargo builds in the Rust plugin along with new tests. The change updated two files with 41 additions and 10 deletions, achieving 100% diff coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for the Rust plugin that resolved cargo build issues and enabled test execution. The change achieved 100% diff coverage per Codecov and was integrated into the main branch by maintainer sergiusens. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcore/snapcraft#2158
(confidence 98%)
Earlier PR #2158 proposed the same fix and was superseded by the reworked changes in #2170.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #2158 rust plugin: fix cargo builds and run tests | snapcraft | closed | PR closed as superseded: the rust-plugin-improvements branch was deleted and the work was reworked and merged as snapcore/snapcraft#2170 (commit 4f80a1051) after cargo test broke cross-compilation. | |
| #2169 Rust plugin improvements | snapcraft | closed | Closed unmerged and superseded by snapcraft#2170, merged as commit 4f80a1051 to fix Cargo builds and add Rust plugin tests. | |
| #2264 Fix issue where Rust cross compile target is ignored | snapcraft | merged | Merged PR #2264 as commit 7e2017783, fixing the Rust plugin to honor cross-compilation targets while preserving a project's existing .cargo/config. | |
| #2434 rust plugin: refactor to use the latest rustup | snapcraft | merged | Merged PR #2434 in commit 3e821ca8d, updating the Rust plugin for current rustup, sharing toolchain storage, and adopting .cargo/config. | |
| #560 rust_plugin: multiple fixes | craft-parts | merged | Merged rust_plugin fixes: removed typing checks around the rust_channel override and added detection/removal of installed compiler plugins via the .data.rel.ro symbol. Squash-merged as fbefe6b8; fixes #559. | |
| #2580 rust plugin: fix linker on i386 | snapcraft | merged | Merged PR #2580 in commit 261ec5978, fixing Rust plugin i386 builds to use the available i686-linux-gnu-gcc linker. | |
| #713 rust plugin: mock downloads in unit tests | snapcraft | merged | Merged PR #713 (commit c8e8e3c10) mocked Cargo downloads in Rust plugin unit tests, resolving LP #1610996. | |
| #1350 rust plugin: Add support for cross-compilation | snapcraft | merged | Merged PR #1350 added --target-arch cross-compilation support for Rust plugin parts in commit 94fb1060e. | |
| #570 rust_plugin: multiple fixes (#560) | craft-parts | merged | Merged backport #570 (8d87e98e) of #560: the Rust plugin now removes compiler plugins from final Snaps and drops a redundant channel override. |