← Back to issue list

rust plugin: fix cargo builds and run tests

View original Github issue

Metadata

Project
snapcraft
Number
#2170
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged fixes for cargo builds in the Rust plugin along with new tests. The change updated two files with 41 additions and 10 deletions, achieving 100% diff coverage.

Suggested action:

No scores available.

Issue body

- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged fixes for cargo builds in the Rust plugin along with new tests. The change updated two files with 41 additions and 10 deletions, achieving 100% diff coverage.
qwen3.6-35b-a3b-mtp-q6 Merged a fix for the Rust plugin that resolved cargo build issues and enabled test execution. The change achieved 100% diff coverage per Codecov and was integrated into the main branch by maintainer sergiusens.
qwen3.6-35b-a3b-mtp-q6 Merged into main. Fixes cargo builds and enables tests for the Rust plugin, achieving 100% diff coverage per Codecov before successful integration.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2158 rust plugin: fix cargo builds and run tests snapcraft closed Changes to fix cargo builds and add tests to the Rust plugin were closed and superseded by PR #2170 after the author discovered cargo test conflicts with cross-compilation, requiring a rework.
89%
#1561 rust plugin: record the Cargo.lock file snapcraft merged Merged to record the Cargo.lock file in the Rust plugin, addressing issue #1475. Approved by two reviewers, passed CI checks, and modified two files (+85/-21 lines).
77%
#2431 rust plugin: update to use latest rustup command options snapcraft merged Merged update to the Rust plugin replacing deprecated rustup command options with current equivalents. Approved by a reviewer, passed CI, modified five files, and maintained 94.5% test coverage.
75%
#2434 rust plugin: refactor to use the latest rustup snapcraft merged Merged Rust plugin refactor for latest rustup. Removed deprecated flags, added command qualifiers, established shared rustup/cargo directory, and standardized config. Approved and passed CI.
74%
#1029 rust plugin: add conditional compilation snapcraft merged Merged into master, adding conditional compilation to the Rust plugin to resolve Launchpad bug #1654485. The update modified seven files (+96/-12 lines), maintained 96.36% code coverage, and integrated without reviewer approval.
73%
#2917 rust plugin: fetch correct (locked) crates during pull snapcraft merged Merged fix for the rust plugin that corrected crate version fetching during pull by checking for Cargo.lock in the source directory instead of the build directory. Updated spread test to prevent regression.
72%
#2373 rust plugin: add support for bases snapcraft merged Merged update to the Rust plugin adding base support for core16 and core18. Resolves Launchpad bug #1798681. Approved, passed CI, and achieved 100% diff coverage with a net zero line change across 23 files.
72%
#2438 rust plugin: new link for rustup snapcraft merged Merged into master after approval and passing CI. Updated the rust plugin to use a new rustup link, addressing LP #1662960. Modified 3 files with 11 additions and 6 deletions.
72%
#560 rust_plugin: multiple fixes craft-parts merged Merged Rust plugin fixes resolving issue #559. Changes remove unnecessary rust_channel override typing checks and improve compiler plugin identification and removal. Approved by reviewers and merged despite an unrelated CI pylint failure.
72%
#713 rust plugin: mock downloads in unit tests snapcraft merged Merged a +7/-1 change to mock downloads in unit tests for the Rust plugin, resolving LP #1610996. The update received informal approval and was integrated without formal CI checks or reviewer sign-off.
72%