← Back to issue list

Support having the snapcraft.yaml in a subdir.

View original Github issue

Metadata

Project
snapcraft
Number
#725
Type
pull request
State
merged
Author
kyrofa
Labels
Created
Updated
Closed

Current evaluation

Merged a fix for a recursion crash when snapcraft.yaml resides in a project subdirectory. The change skips the config directory during processing, resolving Launchpad bug #1600428. Modified 7 files with 85 additions and 4 deletions.

Suggested action:

No scores available.

Issue body

Currently when one puts the `snapcraft.yaml` in a subdirectory of the project (using `source: ..` etc.) snapcraft dies in a sea of recursion. This PR fixes LP: [#1600428](https://bugs.launchpad.net/snapcraft/+bug/1600428) by skipping over the directory containing the snapcraft.yaml if it's a subdirectory of the project.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a fix for a recursion crash when snapcraft.yaml resides in a project subdirectory. The change skips the config directory during processing, resolving Launchpad bug #1600428. Modified 7 files with 85 additions and 4 deletions.
qwen3.6-35b-a3b-mtp-q6 Merged. Fixes recursion crash when snapcraft.yaml resides in a subdirectory by skipping that directory during project scanning. Resolves Launchpad bug #1600428.
qwen3.6-35b-a3b-mtp-q6 Merged. Fixes recursion crash when snapcraft.yaml is placed in a project subdirectory by skipping that directory during processing. Resolves Launchpad bug #1600428.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1073 project: snapcraft.yaml in a snap directory snapcraft merged Merged into master. Defaults new projects to place snapcraft.yaml inside a snap directory while retaining support for legacy locations. Approved and passed CI checks.
73%
#297 Snap: When snapping a directory, look for snap.yaml. snapcraft merged Merged. Resolves Launchpad bug #1541987 by updating directory snapping to locate snap.yaml. The change modifies three files and received maintainer approval.
72%
#1601 snapcraft.yaml: don't re-use build dir snapcraft merged Merged a fix for a source-build directory clash in snapcraft.yaml. The build directory was renamed to apt-build to avoid scriptlet conflicts. Approved by reviewers and passed CI, resolving the failure.
71%
#5664 fix: snapcraft init crash when snapcraft.yaml exists but is empty snapcraft merged Merged a fix for a snapcraft init crash when snapcraft.yaml exists but is empty. The PR addressed review comments, added unit tests, and passed all CI checks before merging.
70%
#2256 local source: don't include .snapcraft directory snapcraft merged Resolved LP: #1791773 by merging a change that excludes the .snapcraft directory from copying and part staleness checks. Approved, passed CI, and merged with a six-line update across two files.
70%