Support having the snapcraft.yaml in a subdir.
Metadata
Current evaluation
Merged PR #725 (commit a3d662744) by kyrofa fixed infinite recursion when snapcraft.yaml lives in a project subdirectory, by skipping the config directory when listing sources. Resolves LP bug #1600428.
Resolution: closed resolved
Reason: The PR was merged into snapcraft's master as commit a3d662744 ("Support having the snapcraft.yaml in a subdir. (#725)"), confirmed present in the repository's commit history. The diff (+85/-4, 7 files) skips the directory containing snapcraft.yaml when it is a subdirectory of the project, resolving Launchpad bug #1600428.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Currently when one puts the `snapcraft.yaml` in a subdirectory of the project (using `source: ..` etc.) snapcraft dies in a sea of recursion. This PR fixes LP: [#1600428](https://bugs.launchpad.net/snapcraft/+bug/1600428) by skipping over the directory containing the snapcraft.yaml if it's a subdirectory of the project.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #725 (commit a3d662744) by kyrofa fixed infinite recursion when snapcraft.yaml lives in a project subdirectory, by skipping the config directory when listing sources. Resolves LP bug #1600428. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #725, commit a3d662744, fixes recursion when snapcraft.yaml is in a project subdirectory by skipping the config directory, resolving LP #1600428. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #725 via commit a3d6627, preventing recursion when snapcraft.yaml is in a project subdirectory and resolving LP #1600428. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix for a recursion crash when snapcraft.yaml resides in a project subdirectory. The change skips the config directory during processing, resolving Launchpad bug #1600428. Modified 7 files with 85 additions and 4 deletions. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Fixes recursion crash when snapcraft.yaml resides in a subdirectory by skipping that directory during project scanning. Resolves Launchpad bug #1600428. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#344
(confidence 35%)
Earlier work by kyrofa on source-subdir copying behaviour (commit 6beb6fec6) related to excluding snap's own parts from source.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1600428 Setting source: .. causes pull to fail | snapcraft (launchpad) | closed | Fixed by snapcore/snapcraft#725, adding support for snapcraft.yaml in a subdirectory and preventing recursive source copying. | |
| #1644350 Runnig snapcraft with sources on parent folders (over one level) causes infinite loops | snapcraft (launchpad) | closed | Fixed by merged snapcore/snapcraft PR #926: local source traversal now excludes generated Snapcraft directories, preventing recursive copies when building from project subdirectories. |