← Back to issue list

Removed statements not used by the tests

View original Github issue

Metadata

Project
snapcraft
Number
#760
Type
pull request
State
merged
Author
come-maiz
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #760 (commit 24624e841) removed statements not exercised by tests from seven files, improving coverage focus for LP #1617149.

Resolution: closed resolved

Reason: PR #760 was merged as commit 24624e841, removing test-unused statements across seven files after the requested retest and reviewer approval.

Evaluated by: mr-cal-bot

No scores available.

Issue body

LP: #1617149

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #760 (commit 24624e841) removed statements not exercised by tests from seven files, improving coverage focus for LP #1617149.
stealth/space-bunny-alpha — closed resolved Merged PR #760 (commit 24624e841) removed test statements not exercised by the suite across seven files, following LP #1617149.
qwen/qwen3.6-35b-a3b — — Successfully merged removal of unused test statements across seven files, netting a reduction of 62 lines. Approved by sergiusens for better coverage and style alignment, with a test rename requested before integration.
qwen3.6-35b-a3b-mtp-q6 — — Merged after approval. The change removed unused statements from the test suite, improving coverage. A reviewer requested a test rename prior to merging.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#488 Remove the integration tests coverage. snapcraft merged Merged PR #488 as commit f2236563f, removing integration-test coverage from four files (+3/-62) and addressing LP #1575383.
74%
#461 test: improve test coverage fetch-service merged Merged PR #461 via commit 76d6134, adding 270 lines of tests across three files; all CI checks passed and two reviewers approved.
73%
#267 Do not report coverage for static and examples tests. snapcraft merged Merged PR #267 in commit dfdc9aaf0, excluding static and example tests from coverage reports and resolving LP bug #1538643.
72%
#278 tests: additional tests to improve coverage fetch-service merged Merged coverage-focused test additions via #278 (commit 095e41a), changing 10 files (+386/-60) with two approvals and no reported CI failures.
72%
#2421 tests: remove obsolete snap and external tests snapcraft merged Merged PR #2421 in commit 707395546, deleting 77 obsolete snap/external-test files and 2,959 lines despite a negligible coverage decrease.
70%