tests: remove obsolete snap and external tests
Metadata
Current evaluation
Merged PR #2421 in commit 707395546, deleting 77 obsolete snap/external-test files and 2,959 lines despite a negligible coverage decrease.
Resolution: closed resolved
Reason: The cleanup was merged into master as commit 707395546. A maintainer approved the merge and noted that the Plainbox failures were unrelated.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2421 in commit 707395546, deleting 77 obsolete snap/external-test files and 2,959 lines despite a negligible coverage decrease. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged cleanup removed 77 obsolete snap/external-test files and 2,959 lines; the reported Plainbox failures and 0.01% coverage drop were deemed non-blocking. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2421 in commit 707395546, removing 77 obsolete snap/external-test files and 2,959 lines; maintainers accepted minor coverage loss and unrelated plainbox failures. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after maintainer approval, removing obsolete snap and external tests. Accepted despite minor coverage drop and unrelated CI failures, though later noted to break documentation. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged by maintainer sergiusens, the change removed obsolete snap and external tests. Despite a 0.01% coverage drop and unrelated test failures, it was approved. Later feedback noted the removal broke documentation. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1849 tests: add snap not found tests | snapcraft | merged | Merged missing-snap test coverage; snapcraft PR #1849 landed as commit 54cf2bd9e. | |
| #1948 tests: move test files out of the snapcraft dir | snapcraft | merged | Merged as commit 55ad11ccc: a pure test-suite reorganization (788 files, +615/-589) moving test files out of the snapcraft/ package dir into top-level tests/; approved by a maintainer and now reflected in the current tests/unit layout. | |
| #458 test: improve test coverage | fetch-service | merged | Merged as commit 47b7773, adding 370 lines of tests across five files; unit tests, linters, Snap builds/tests, and security scans all passed. | |
| #347 tests: reformat snap inspector test parameters | fetch-service | merged | Merged PR #347 as commit 51ce4ce, reformatting snap inspector test parameters across three files (+176/-74). | |
| #5791 test: delete unused tests | snapcraft | merged | Merged as commit 3d1554584, removing 55 lines of obsolete, long-unused v1-plugin spread tests while retaining core20 coverage for external plugins. | |
| #2353 tests: remove dependency on snapcraft for integration tests | snapcraft | merged | PR #2353 by sergiusens merged as commit 6a7c860c4, dropping snapcraft imports from integration tests (27 files, +956/-733) so the suite no longer depends on snapcraft and tests stay independent, alongside the bases/multipass cleanup. | |
| #1877 tests: move test files out of the snapcraft dir | snapcraft | closed | Closed unmerged after conflicts; the test reorganization was redone and merged via snapcraft#1948 at commit 55ad11ccc, moving tests out of the snapcraft package. | |
| #1051 misc: remove snapd "submodule" | snapcraft | merged | Merged PR #1051 as commit f62ac0ce1, removing the obsolete snapd testing-tools submodule reference in a one-line cleanup. | |
| #911 Remove the outdated all snaps image set up for snaps tests | snapcraft | merged | Merged PR #911 removed the outdated all-snaps image setup from snap tests, resolving Launchpad #1642410. | |
| #2130 tests: remove obsolete env var | snapcraft | merged | Merged PR #2130 as commit 5305ac01c, removing obsolete SNAPCRAFT_SEND_ERROR_DATA test configuration after the related error-data logic was removed. |