tests: remove obsolete snap and external tests
Metadata
Current evaluation
Merged after maintainer approval, removing obsolete snap and external tests. Accepted despite minor coverage drop and unrelated CI failures, though later noted to break documentation.
Suggested action: —
No scores available.
Issue body
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [ ] Have you successfully run `./runtests.sh static`?
- [ ] Have you successfully run `./runtests.sh tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after maintainer approval, removing obsolete snap and external tests. Accepted despite minor coverage drop and unrelated CI failures, though later noted to break documentation. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged by maintainer sergiusens, the change removed obsolete snap and external tests. Despite a 0.01% coverage drop and unrelated test failures, it was approved. Later feedback noted the removal broke documentation. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged by maintainer sergiusens, the change removed obsolete snap and external tests. Approved despite a 0.01% coverage drop and unrelated test failures, the commit was later noted to have broken documentation generation. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1849 tests: add snap not found tests | snapcraft | merged | Merged tests for missing snap scenarios. Approved by two reviewers and integrated into the codebase despite unresolved review comments and reported integration test timeouts. | |
| #1542 tests: add integration tests for build snaps | snapcraft | merged | Merged integration tests for build snaps. Approved by two reviewers and passed CI. Two test scenarios omitted due to known bugs. | |
| #3609 tests: move legacy snapcraft tests (CRAFT-728) | snapcraft | merged | Merged following reviewer approval and passing CI. Relocated unit tests for the renamed snapcraft_legacy package to tests/legacy, modifying 313 files (+579/-564 lines). | |
| #1877 tests: move test files out of the snapcraft dir | snapcraft | closed | Approved and passing local tests, the changes to move test files out of the snapcraft directory were abandoned after a merge conflict arose. The maintainer closed the request to retry the file relocation later. | |
| #990 tests: fix snaps tests in armhf | snapcraft | merged | Merged into master to fix failing snap tests on the armhf architecture. Approved by a reviewer, the change updated 11 files and resolved CI failures without altering overall code coverage. | |
| #1180 tests: support snap directory in external tests | snapcraft | merged | Merged after approval. Adds support for the snap directory in external tests. Briefly held due to an unrelated etcd directory breaking docker tests, then merged once resolved. | |
| #2014 integration tests: snap tests shouldn't be arch-specific | snapcraft | merged | Merged a change removing architecture-specific constraints from snap integration tests. Approved by one reviewer with a two-line modification across a single file. | |
| #85 test: cleanup test now that we have a new enough snapcraft | snapcraft-rocks | merged | Merged test cleanup after upgrading to a stable snapcraft version. Removes six lines of outdated test code. Approved by one reviewer, passed all CI checks, and successfully merged. | |
| #911 Remove the outdated all snaps image set up for snaps tests | snapcraft | merged | Merged removal of the outdated all snaps image setup for snaps tests. Approved by one reviewer, modifying two files with a net reduction of 33 lines. References Launchpad bug #1642410. | |
| #1948 tests: move test files out of the snapcraft dir | snapcraft | merged | Merged reorganization of the test suite, moving test files out of the snapcraft directory. Approved by one reviewer, the change touched 788 files with 615 additions and 589 deletions. |