Make source-depth a parameter and opt-in
Metadata
Current evaluation
Merged #814 in commit 190463c3c, making source-depth an explicit, opt-in part property instead of enabling shallow Git clones by default.
Resolution: closed resolved
Reason: PR #814 was merged by maintainer sergiusens. Commit 190463c3c records the accepted implementation, which passed review despite concerns about the new default.
Evaluated by: mr-cal-bot
No scores available.
Issue body
LP: #1617783
Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged #814 in commit 190463c3c, making source-depth an explicit, opt-in part property instead of enabling shallow Git clones by default. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged snapcraft#814 in commit 190463c3c, making source-depth an explicit opt-in part property and full Git clones the default instead of shallow clones. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #814 as commit 190463c3c, making source-depth an explicit, opt-in part property instead of enabling shallow Git clones by default. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #814 as commit 190463c3c, making source-depth an explicit, opt-in part property instead of shallow-cloning Git sources by default. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #814 in commit 190463c3c, making source-depth opt-in; Git sources are no longer shallow-cloned by default. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #814 merged as commit 190463c3c, making source-depth an explicit opt-in part property instead of always shallow-cloning. Reverts the default depth-1 clone from #248 and fixes LP bug #1617783 (shallow clone lost tags). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #814 (commit 190463c3c), making source-depth an explicit, opt-in part property instead of applying shallow Git clones by default. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Makes source-depth a configurable parameter that is opt-in by default. Approved after referencing Launchpad bug #1617783 for rationale, despite reviewer reservations about changing the default behavior. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after making source-depth an opt-in parameter. The maintainer changed the default behavior per Launchpad bug #1617783 rationale. Reviewers approved the implementation despite reservations about the default change. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#829
(confidence 85%)
Follow-up PR #829 corrected argument typing when source handling is called with a depth.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1476 fix(git-source): only shallow fetch if a source-depth is provided | craft-parts | merged | Merged as commit f1e2c927 (#1476): git-source now shallow-clones only when a non-zero source-depth is set, so full-hash source-commit no longer forces a shallow fetch. Released in craft-parts 2.28.1 and merged back via #1481. | |
| #248 Git source: Make a shallow clone. | snapcraft | merged | Merged #248 (commit 6ebd8e68d; merge 321b13277), changing Git sources from full clones to depth-1 shallow clones and resolving LP #1536696. | |
| #1965792 source-depth should propagate to git submodules | snapcraft (launchpad) | open | Feature request: source-depth only shallow-clones the parent repo; git submodule update runs without --depth, so submodule-heavy builds (e.g. qt5) fetch full submodule history. Untriaged, no maintainer response. |