← Back to issue list

sources: fix type when calling with depth

View original Github issue

Metadata

Project
snapcraft
Number
#829
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged in PR #829 (commit b492a5a41), fixing the argument type used when source handling is called with depth; addresses Launchpad bug #1627772.

Resolution: closed resolved

Reason: The approved PR was merged as commit b492a5a41, correcting how the depth argument was passed and resolving the problem tracked by Launchpad #1627772.

Evaluated by: mr-cal-bot

No scores available.

Issue body

LP: #1627772 Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in PR #829 (commit b492a5a41), fixing the argument type used when source handling is called with depth; addresses Launchpad bug #1627772.
stealth/space-bunny-alpha — closed resolved Merged as snapcraft#829 via b492a5a41, fixing the type passed when calling sources with depth (LP #1627772).
qwen/qwen3.6-35b-a3b — — Merged a fix for a type error when calling sources with depth. The author declined a reviewer's suggestion to validate git commit counts, stating the test is only a gimmick for an unusual scenario. The change modifies 4 files with 29 additions and 2 deletions.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix for a type error when calling sources with depth. The maintainer declined reviewer suggestions to add git commit count checks and file:// URL handling, noting the test is a gimmick for an unusual scenario and avoiding git behavior testing.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft (launchpad)#1627772 (confidence 96%)

    Launchpad bug #1627772 is cited as the originating defect.

  • Related To: snapcraft#814 (confidence 90%)

    PR #814 introduced source-depth as an opt-in parameter and established the affected call path.

Related issues

No related issues found above the similarity threshold.