← Back to issue list

`sign-build` to prompt users for key selection

View original Github issue

Metadata

Project
snapcraft
Number
#848
Type
pull request
State
merged
Author
cprov
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #848 (commit d0b49816f) made sign-build prompt for key selection and avoid stray/empty '-build' files, fixing LP #1629966 and #1629984.

Resolution: closed resolved

Reason: PR #848 was merged as commit d0b49816f. The change added interactive key selection and prevented failed signing from creating stray or empty '-build' files.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This way we can handle cases when the keyring is not setup, the selected key name is not present or selected key is not registered (LP #1629966). Also prevent `snap sign-build` failures to create stray/empty '-build' files (LP #1629984).

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #848 (commit d0b49816f) made sign-build prompt for key selection and avoid stray/empty '-build' files, fixing LP #1629966 and #1629984.
stealth/space-bunny-alpha — closed resolved Merged in #848 (d0b49816f): sign-build now prompts for a valid registered key and avoids stray/empty '-build' files, addressing LP #1629966 and LP #1629984.
stealth/space-bunny-alpha — closed resolved Merged PR #848 (commit d0b49816f) added sign-build key selection prompts and prevented stray/empty '-build' files, addressing LP #1629966 and #1629984.
stealth/space-bunny-alpha — closed resolved Merged #848 (d0b49816f), adding key-selection prompts to sign-build and preventing failures from leaving stray or empty -build files.
qwen/qwen3.6-35b-a3b — — Merged. Adds key selection prompting to sign-build to handle missing or unregistered keys and prevents stray empty build files. Commit messages were reformatted to match contribution guidelines before final merge.
qwen3.6-35b-a3b-mtp-q6 — — Merged after commit formatting was adjusted per guidelines. Adds key selection prompting for sign-build and prevents stray empty build files on failure, resolving launchpad bugs 1629966 and 1629984.

Update history

No update history recorded yet.

Related work

  • Related To: launchpad#1629966 (confidence 99%)

    Missing keyring, key-name, and registration cases addressed by the merged change.

  • Related To: launchpad#1629984 (confidence 99%)

    Stray or empty '-build' files caused by sign-build failures addressed by the merged change.

Related issues

Issue Project State Summary Similarity
#1629984 trying to sign-build without keys leaves a -build file, empty snapcraft (launchpad) closed Merged canonical/snapcraft PR #848 (d0b49816f), fixing failed sign-build runs that left empty "-build" files by selecting a key before writing output.
73%
#831 'sign-build' implementation. snapcraft merged Merged as commit ded7281c9, adding sign-build to generate, sign, and optionally push snap-build assertions; superseded PR #795.
71%