← Back to issue list

'sign-build' implementation.

View original Github issue

Metadata

Project
snapcraft
Number
#831
Type
pull request
State
merged
Author
cprov
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit ded7281c9, adding sign-build to generate, sign, and optionally push snap-build assertions; superseded PR #795.

Resolution: closed resolved

Reason: PR #831 was merged into main as commit ded7281c9, delivering the sign-build command and Store assertion workflow.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Supporting snap-build assertion generation and pushing to the Store. Implements `snapcraft sign-build <snap>` as a discreet command for generating, signing and optionally pushing snap-build assertions to the store. Next stage, when snap-build start to be required/checked on Store and snapd side, we will extend push & release commands to take this in consideration as well. Supersedes https://github.com/snapcore/snapcraft/pull/795 since Caio on leave this week. https://bugs.launchpad.net/snapcraft/+bug/1628679

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit ded7281c9, adding sign-build to generate, sign, and optionally push snap-build assertions; superseded PR #795.
stealth/space-bunny-alpha — closed resolved Merged: `sign-build` command (generates, signs and pushes snap-build assertions to the Store) landed as commit ded7281c9; superseded earlier WIP #795. Integration test fixes followed in #839 (b67a60d58).
stealth/space-bunny-alpha — closed resolved Merged PR #831 (commit ded7281c9) added sign-build to generate, sign, and optionally push snap-build assertions, superseding PR #795.
qwen/qwen3.6-35b-a3b — — Merged the snapcraft sign-build command for generating, signing, and pushing assertions. Supersedes PR 795. Lint errors were fixed and design concerns regarding future release integration were resolved with reviewer approval.
qwen3.6-35b-a3b-mtp-q6 — — Merged implementation of the snapcraft sign-build command for generating, signing, and pushing snap-build assertions. Lint errors were fixed, integration tests deferred pending snapd 2.15, design clarified with reviewers, superseding #795.

Update history

No update history recorded yet.

Related work

  • Duplicate Of: snapcraft#795 (confidence 100%)

    PR #831 explicitly superseded the earlier sign-build implementation in PR #795.

  • Related To: snapcraft#839 (confidence 98%)

    Follow-up PR #839, merged as b67a60d58, fixed the new command's integration tests.

Related issues

Issue Project State Summary Similarity
#1628679 Implement 'sign-build' command snapcraft (launchpad) closed Implemented via snapcore/snapcraft PR #831 (commit ded7281c9), which added `snapcraft sign-build <snap>` to generate, sign and optionally push snap-build assertions. Superseded earlier WIP PR #795; still present in snapcraft/commands/keys.py.
83%
#6228 refactor: migrate sign-build command snapcraft merged Merged PR #6228 as commit 2904d0be2, migrating the sign-build command from Snapcraft's legacy codebase as part of SNAPCRAFT-1320.
77%
#5826 fix: parse a snap file for the sign-build command snapcraft merged Merged PR #5826 (commit bf00a385e) fixed sign-build snap-file parsing and removed duplicate --local help text; it fixes #5618.
74%
#5618 sign-build --local just doesn't work snapcraft closed Fixed by merged PR #5826 (commit bf00a385e, "fix: parse a snap file for the sign-build command"), which declared the missing snap-file argument in the legacy sign-build command; tracked internally as SNAPCRAFT-1180.
74%
#839 Fixing 'sign-build' integration tests. snapcraft merged Merged in canonical/snapcraft#839 as commit b67a60d58, fixing sign-build integration tests by registering snap names and exposing them through the fake account-info endpoint.
72%
#848 `sign-build` to prompt users for key selection snapcraft merged Merged PR #848 (commit d0b49816f) made sign-build prompt for key selection and avoid stray/empty '-build' files, fixing LP #1629966 and #1629984.
71%