← Back to issue list

sources: Add RPM source

View original Github issue

Metadata

Project
snapcraft
Number
#870
Type
pull request
State
merged
Author
Conan-Kudo
Labels
—
Created
Updated
Closed

Current evaluation

RPM source support was merged via snapcraft#870 in commit 973e99a59, adding RPM handling and tests with the final test fix.

Resolution: closed resolved

Reason: The pull request was approved and merged; commit 973e99a59 records the change as “sources: Add RPM source (#870).” Review discussion also confirms the final test adjustment before merge.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Signed-off-by: Neal Gompa ngompa13@gmail.com

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved RPM source support was merged via snapcraft#870 in commit 973e99a59, adding RPM handling and tests with the final test fix.
stealth/space-bunny-alpha — closed resolved RPM source support was merged in canonical/snapcraft#870 via commit 973e99a59, with a fixup updating the extraction test to use assertCountEqual.
qwen/qwen3.6-35b-a3b — — Added RPM source support. Merged after resolving test failures in test_extract_and_keep_rpmfile by switching to assertCountEqual and fixing file handling. Approved by three reviewers following successful CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Added RPM source support to snapcraft. Test failures from list ordering were resolved by switching to assertCountEqual. All checks passed and the changes were merged.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#966 (confidence 98%)

    The RPM handler was later refactored into a dedicated module.

Related issues

Issue Project State Summary Similarity
#1640296 Support rpm as source snapcraft (launchpad) closed RPM-as-source landed in snapcraft via merged PR snapcore/snapcraft#870 (commit 973e99a5), mirroring the deb source; the LP bug was closed by maintainer with a link to that PR. Handler was later refactored into snapcraft/sources/_rpm.py (#966) and now lives in craft-parts.
77%
#377 sources: add an rpm source handler craft-parts merged Merged PR #377 added an RPM source handler for CRAFT-1583 in commit 7775681d, changing 10 files (+482/-5).
77%
#966 sources: refactor rpm source into module. snapcraft merged Merged PR snapcraft#966 (merge commit 07697e4f4) extracted the RPM source handler into snapcraft/sources/_rpm.py as part of the ongoing refactor for LP bug #1648906; +131/-90 lines, no functional change.
77%