← Back to issue list

sources: refactor rpm source into module.

View original Github issue

Metadata

Project
snapcraft
Number
#966
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR snapcraft#966 (merge commit 07697e4f4) extracted the RPM source handler into snapcraft/sources/_rpm.py as part of the ongoing refactor for LP bug #1648906; +131/-90 lines, no functional change.

Resolution: closed resolved

Reason: The PR itself was merged into master with merge commit 07697e4f4, completing the extraction of the Rpm source into sources/_rpm.py. It is one step in a series of identical refactor PRs (#965 for Mercurial, #967 for script) tracked by Launchpad bug snapcraft#1648906.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR makes more progress on LP: [#1648906](https://bugs.launchpad.net/snapcraft/+bug/1648906) by extracting the Rpm source into `sources/_rpm.py`.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR snapcraft#966 (merge commit 07697e4f4) extracted the RPM source handler into snapcraft/sources/_rpm.py as part of the ongoing refactor for LP bug #1648906; +131/-90 lines, no functional change.
stealth/space-bunny-alpha — closed resolved Merged PR #966 extracted RPM source logic into sources/_rpm.py, advancing Launchpad bug snapcraft#1648906; merge commit 07697e4f4.
qwen/qwen3.6-35b-a3b — — Merged a refactor extracting RPM source logic into a dedicated sources/_rpm.py module. Part of ongoing work on Launchpad bug #1648906, the change modified four files (+131/-90 lines) and slightly increased overall code coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master. Refactored RPM source extraction into a dedicated sources/_rpm.py module, improving organization and slightly increasing test coverage.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#965 (confidence 92%)

    Sibling PR merged as e42bc812, same refactor for the Mercurial source under LP #1648906

  • Related To: snapcraft#967 (confidence 92%)

    Follow-up merged PR (d80be9fe0) doing the same extraction for the Script source

  • Related To: snapcraft (launchpad)#1648906 (confidence 70%)

    Referenced Launchpad bug tracking the overall sources refactor effort

Related issues

Issue Project State Summary Similarity
#1640296 Support rpm as source snapcraft (launchpad) closed RPM-as-source landed in snapcraft via merged PR snapcore/snapcraft#870 (commit 973e99a5), mirroring the deb source; the LP bug was closed by maintainer with a link to that PR. Handler was later refactored into snapcraft/sources/_rpm.py (#966) and now lives in craft-parts.
80%
#870 sources: Add RPM source snapcraft merged RPM source support was merged via snapcraft#870 in commit 973e99a59, adding RPM handling and tests with the final test fix.
77%
#955 sources: convert to package. snapcraft merged Merged PR #955 (commit 0ef7dc218) converted snapcraft/internal/sources.py into a package, groundwork for LP bug #1648906. Follow-ups #957 and #961-#970 then split each source handler into its own module.
71%
#377 sources: add an rpm source handler craft-parts merged Merged PR #377 added an RPM source handler for CRAFT-1583 in commit 7775681d, changing 10 files (+482/-5).
71%