sources: refactor rpm source into module.
Metadata
Current evaluation
Merged a refactor extracting RPM source logic into a dedicated sources/_rpm.py module. Part of ongoing work on Launchpad bug #1648906, the change modified four files (+131/-90 lines) and slightly increased overall code coverage.
Suggested action: —
No scores available.
Issue body
This PR makes more progress on LP: [#1648906](https://bugs.launchpad.net/snapcraft/+bug/1648906) by extracting the Rpm source into `sources/_rpm.py`.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a refactor extracting RPM source logic into a dedicated sources/_rpm.py module. Part of ongoing work on Launchpad bug #1648906, the change modified four files (+131/-90 lines) and slightly increased overall code coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Refactored RPM source extraction into a dedicated sources/_rpm.py module, improving organization and slightly increasing test coverage. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged refactoring that extracts RPM source logic into a dedicated module at sources/_rpm.py. The change improved overall code coverage by less than 0.01%, maintaining 96.24%. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #961 sources: refactor local source into module. | snapcraft | merged | Merged after approval and CI. Refactored the local source into sources/_local.py, advancing Launchpad bug #1648906. Modified four files with a +236/-191 line change and slightly increased overall code coverage. | |
| #968 sources: refactor subversion source into module. | snapcraft | merged | Merged refactoring that extracts the Subversion source handler into a dedicated module. Advances Launchpad bug #1648906, passed coverage checks, and received author approval. Net change: +170/-129 lines across four files. | |
| #870 sources: Add RPM source | snapcraft | merged | Added RPM source support. Merged after resolving test failures in test_extract_and_keep_rpmfile by switching to assertCountEqual and fixing file handling. Approved by three reviewers following successful CI checks. | |
| #957 sources: refactor base sources into module. | snapcraft | merged | Merged following two approvals and passing CI checks. Refactored Base and FileBase sources into sources/_base.py, increasing test coverage by 1.20% and progressing work on Launchpad bug #1648906. | |
| #377 sources: add an rpm source handler | craft-parts | merged | Merged to add an RPM source handler, resolving CRAFT-1583. Approved by two reviewers, the change adds 482 lines across ten files to implement RPM package source handling. |