← Back to issue list

Always respect go-buildtags

View original Github issue

Metadata

Project
snapcraft
Number
#888
Type
pull request
State
merged
Author
stgraber
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #888 (commit d817b1dbb) made the go plugin always pass go-buildtags, fixing LXD snap builds so they link the system libsqlite3 instead of the bundled copy (~20x faster).

Resolution: closed resolved

Reason: The PR was merged into snapcraft as commit d817b1dbb ("Always respect go-buildtags (#888)"), changing the Go plugin so go-buildtags are always applied, not only for local-tree builds. The author verified via ldd that prime/bin/lxd now links /usr/lib/x86_64-linux-gnu/libsqlite3.so.0.

Evaluated by: mr-cal-bot

No scores available.

Issue body

There is no mention in documentation that go-buildtags should only apply to building from the local tree and since those tags are global to the build anyway, it's best to always pass them. One need for this change is the LXD snap. Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #888 (commit d817b1dbb) made the go plugin always pass go-buildtags, fixing LXD snap builds so they link the system libsqlite3 instead of the bundled copy (~20x faster).
stealth/space-bunny-alpha — closed resolved Merged PR #888 in commit d817b1dbb so go-buildtags are always respected, fixing LXD Snap builds to link system SQLite instead of the bundled library.
qwen/qwen3.6-35b-a3b — — Merged to always pass go-buildtags globally. This ensures the LXD snap links against system libsqlite3 instead of a bundled copy, improving performance by roughly 20x. The change updates build tag handling across the codebase.
qwen3.6-35b-a3b-mtp-q6 — — Merged to always pass go-buildtags during compilation. This change enables the LXD snap to link against the system libsqlite3 instead of a bundled version, improving runtime performance by approximately 20x.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#733 (confidence 85%)

    Merged PR #733 (commit 59d4acf8a) originally introduced the go-buildtags property, documented as local-tree only; #888 corrects that behaviour.

Related issues

Issue Project State Summary Similarity
#733 Add the go-buildtags property to the go plugin snapcraft merged Merged PR #733 added the go-buildtags property to Snapcraft's Go plugin, implementing LP #1609623 in commit 59d4acf8a.
73%
#1609623 go plugin has no build tags snapcraft (launchpad) closed Added Go build-tag support via the go-buildtags property in snapcraft PR #733 (commit 59d4acf8a), later refined by PR #888.
72%