← Back to issue list

Add the go-buildtags property to the go plugin

View original Github issue

Metadata

Project
snapcraft
Number
#733
Type
pull request
State
merged
Author
come-maiz
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #733 added the go-buildtags property to Snapcraft's Go plugin, implementing LP #1609623 in commit 59d4acf8a.

Resolution: closed resolved

Reason: PR #733 was merged and landed as commit 59d4acf8a, adding the requested Go plugin build-tag configuration and associated schema and tests.

Evaluated by: mr-cal-bot

No scores available.

Issue body

LP: #1609623

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #733 added the go-buildtags property to Snapcraft's Go plugin, implementing LP #1609623 in commit 59d4acf8a.
stealth/space-bunny-alpha — closed resolved Merged PR #733 added a go-buildtags property to the Go plugin, fixing LP #1609623 (vault snap builds needed build tags). Merged as commit 59d4acf8a.
stealth/space-bunny-alpha — closed resolved Merged PR #733 added the go-buildtags property to Snapcraft's Go plugin for LP #1609623, resolving the request in commit 59d4acf8a.
qwen/qwen3.6-35b-a3b — — Merged by maintainer come-maiz, adding the go-buildtags property to the go plugin. The update modifies two files with 166 additions and 5 deletions, implementing the feature requested in LP #1609623.
qwen3.6-35b-a3b-mtp-q6 — — Merged the go-buildtags property addition to the Go plugin, resolving LP: #1609623. The maintainer requested a retest before final integration.

Update history

No update history recorded yet.

Related work

  • Related To: Launchpad#1609623 (confidence 100%)

    Original request cited by PR #733.

  • Related To: snapcraft#888 (confidence 90%)

    Follow-up merged PR that made Go build tags always respected, in commit d817b1dbb.

Related issues

Issue Project State Summary Similarity
#1609623 go plugin has no build tags snapcraft (launchpad) closed Added Go build-tag support via the go-buildtags property in snapcraft PR #733 (commit 59d4acf8a), later refined by PR #888.
86%
#1640184 tags need to apply to all go packages snapcraft (launchpad) closed Fixed by merged PR snapcore/snapcraft#888 (commit d817b1dbb): the Go plugin now honors go-buildtags for every package, including when go-packages is defined.
75%
#99 go plugin: implement a go-packages plugin property snapcraft merged Merged PR #99 added the go-packages property to Snapcraft's Go plugin in commit 657db2cf1, merged via 9d3d05044.
75%
#888 Always respect go-buildtags snapcraft merged Merged PR #888 (commit d817b1dbb) made the go plugin always pass go-buildtags, fixing LXD snap builds so they link the system libsqlite3 instead of the bundled copy (~20x faster).
73%
#1650606 Updated go plugin to use get_build_properties() snapcraft (launchpad) closed Go plugin build-property handling was fixed by merged snapcore/snapcraft PR #997 in commit 0b4239ce7, with added test coverage.
71%