ftp source support
Metadata
Current evaluation
Merged as snapcraft#900 via commit eba7dd2b1, adding FTP source downloads through urllib and progress reporting via the refactored source indicator.
Resolution: closed resolved
Reason: The approved pull request was merged as commit eba7dd2b1. It implemented FTP source handling and added download progress support through indicator refactoring.
Evaluated by: mr-cal-bot
No scores available.
Issue body
As requested on bug https://bugs.launchpad.net/snappy/+bug/1602323
This adds support for FTP sources, using urllib was the quickest choice, and with some refactor of the indicator module, adding a progressbar was possible too. If using ftplib or others is preferred let me know, but I went for the fastest and safer way.
In theory this path could be used also for http(s) downloads, but not to change what we've done so far, I've left that job to the nicer `requests` library. `requests` being an HTTP only library has no native suppot for this, while trying to use something like [requests-ftp](https://pypi.python.org/pypi/requests-ftp) I don't think is a choice (looking quite immature).
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as snapcraft#900 via commit eba7dd2b1, adding FTP source downloads through urllib and progress reporting via the refactored source indicator. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #900 as commit eba7dd2b1, adding FTP source downloads via urllib and a source-indicator refactor that enables download progress reporting. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged to add FTP source support using urllib and a progress bar refactor. Resolved autopkgtest timeout issues via a proxy workaround. Approved by reviewers, rebased on master, and integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged after adding FTP source support to snapcraft via urllib and refactoring the indicator module for progress tracking. Autopkgtest failures were resolved with a proxy workaround, and the branch was rebased on master prior to merge. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1602323 Add FTP support for remote files | snapcraft (launchpad) | closed | FTP source support requested in 2016 was implemented upstream: snapcraft PR #900 "sources: add ftp support" merged as commit eba7dd2b1, adding ftp:// URL downloads via urllib. Maintainer sergiusens linked that PR on the Launchpad bug, which was then closed. | |
| #1647751 The ftp integration test is unreliable | snapcraft (launchpad) | closed | Flaky FTP source integration test fixed by pointing it at a more stable server, in commit a0c726e00 (snapcore/snapcraft#950); the follow-up #1169 later updated that FTP source again. |