← Back to issue list

ftp source support

View original Github issue

Metadata

Project
snapcraft
Number
#900
Type
pull request
State
merged
Author
3v1n0
Labels
Created
Updated
Closed

Current evaluation

Merged to add FTP source support using urllib and a progress bar refactor. Resolved autopkgtest timeout issues via a proxy workaround. Approved by reviewers, rebased on master, and integrated.

Suggested action:

No scores available.

Issue body

As requested on bug https://bugs.launchpad.net/snappy/+bug/1602323 This adds support for FTP sources, using urllib was the quickest choice, and with some refactor of the indicator module, adding a progressbar was possible too. If using ftplib or others is preferred let me know, but I went for the fastest and safer way. In theory this path could be used also for http(s) downloads, but not to change what we've done so far, I've left that job to the nicer `requests` library. `requests` being an HTTP only library has no native suppot for this, while trying to use something like [requests-ftp](https://pypi.python.org/pypi/requests-ftp) I don't think is a choice (looking quite immature).

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged to add FTP source support using urllib and a progress bar refactor. Resolved autopkgtest timeout issues via a proxy workaround. Approved by reviewers, rebased on master, and integrated.
qwen3.6-35b-a3b-mtp-q6 Merged after adding FTP source support to snapcraft via urllib and refactoring the indicator module for progress tracking. Autopkgtest failures were resolved with a proxy workaround, and the branch was rebased on master prior to merge.
qwen3.6-35b-a3b-mtp-q6 Merged after adding FTP source support via urllib and a progress bar refactor. Resolved autopkgtest connection timeouts with a proxy workaround and rebased on master prior to integration.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1169 tests: update the ftp source for integration test snapcraft merged Merged test updates to replace the shut-down kernel.org FTP source with a local server, preventing future integration failures. Added python3-pyftpdlib to dependencies. Approved after minor naming feedback.
74%
#950 tests: Use a more stable ftp source snapcraft merged Merged into master after reviewer approval and passing code coverage checks. Updates test configuration to use a more stable FTP source, resolving LP: #1647751 with a minimal two-line change.
73%