← Back to issue list

Update HACKING.md

View original Github issue

Metadata

Project
snapcraft
Number
#910
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Docs-only PR merged as commit bccc3e4f9 ("Update HACKING.md (#910)", Nov 2016): dropped an obsolete testing section and relocated the testing instructions after the dependency-install steps in HACKING.md.

Resolution: closed resolved

Reason: The PR itself was the fix and was merged to the default branch as commit bccc3e4f9, confirmed by the HACKING.md history entry "Update HACKING.md (#910)" and the recorded merge state with +16/-32 lines. It reordered and trimmed the testing/dependency instructions in HACKING.md as described in the PR body.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Removed a very obsolete section about testing, added it to the end after installing and making sure the correct set of dependencies are in place.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Docs-only PR merged as commit bccc3e4f9 ("Update HACKING.md (#910)", Nov 2016): dropped an obsolete testing section and relocated the testing instructions after the dependency-install steps in HACKING.md.
stealth/space-bunny-alpha — closed resolved Merged #910 (commit bccc3e4f9), removing obsolete HACKING.md testing instructions and relocating them after dependency setup.
qwen/qwen3.6-35b-a3b — — Merged a documentation update to HACKING.md that removes an obsolete testing section and relocates it after dependency installation. The change was approved by a reviewer with a follow-up question.
qwen3.6-35b-a3b-mtp-q6 — — Merged an update to HACKING.md that moves an obsolete testing section to the end, placing it after dependency installation instructions. Approved with a minor question.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#1394 (confidence 70%)

    Follow-up commit ddf06b948 "tests: document the test suites in the snapcraft repo (#1394)" later fleshed out the test documentation that #910 only repositioned.

  • Related To: canonical/snapcraft#1274 (confidence 55%)

    Commit 9eb229928 "docs: simple explanation of what the test groups mean. (#1274)" further clarified the test groups described in the relocated HACKING.md section.

Related issues

Issue Project State Summary Similarity
#55 Add hacking to README.md snapcraft merged Docs-only PR by ted-gould merged via commit 35af890e6, adding the hacking project to README.md (+1/-1). Approved by sergiusens (:+1:) on 2015-10-30.
78%
#1311 add missing VCS dependencies to HACKING.md snapcraft merged Merged PR #1311 in commit 034cb615d9, adding omitted VCS packages to HACKING.md so the documented test setup included the required dependencies.
77%
#564 Changed apt-get to apt in HACKING.md snapcraft merged Docs-only PR: HACKING.md switched from apt-get to apt for setup instructions. Merged as commit 14bbd1bf7 ("Change apt-get to apt in HACKING.md (#564)"), addressing Launchpad bug 1591421.
76%
#162 docs(HACKING): update commit message guidelines starbase merged Merged PR #162 into main via commit 4b2c78e, making HACKING commit-message guidance more descriptive and authoritative.
76%
#229 Move HACKING.rst to readthedocs starbase closed Resolved by merged PR #448 (commit ebfec44), replacing HACKING.md with a reusable CONTRIBUTING.md contribution guide.
76%
#2725 Update HACKING.md snapcraft closed The unmerged two-line HACKING.md update was left at pending review with no comments or CI, and repository history shows no resolving commit for #2725.
75%
#215 docs: add CONTRIBUTING.md imagecraft merged Merged PR #215 in commit b0aa9f2, replacing HACKING.md with a 312-line CONTRIBUTING.md aligned to the project's contribution model.
74%
#1625236 the testing docs in the HACKING file are incomplete and outdated snapcraft (launchpad) closed Testing docs were refreshed by merged PR #910 (commit bccc3e4f9); PR #1394 later added fuller explanations of Snapcraft's test suites.
74%
#791 docs: update CONTRIBUTING.md craft-application merged Docs-only PR #791 merged as commit 60bc3fae, rewriting CONTRIBUTING.md (+278/-319, 3 files) and deleting HACKING.md. Approved by 2 reviewers; only the OSV-scanner check failed.
73%
#297 (draft): docs: reformat README, add HACKING craft-providers closed Superseded by merged PR #296; its README.rst conversion and HACKING.rst documentation landed in commit 1e16ba5.
72%