← Back to issue list

meta: icon is now dedeprecated

View original Github issue

Metadata

Project
snapcraft
Number
#914
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

PR #914 merged as commit 4a4435cbe, re-deprecating the icon deprecation: the icon entry in snapcraft.yaml is again the preferred method, overriding any icon in the setup directory (LP: #1610268).

Resolution: closed resolved

Reason: The PR itself was merged into the snapcraft repository as commit 4a4435cbe ('meta: icon is now dedeprecated (#914)'), a +10/-14 line change to 2 files in snapcraft/meta.py. Maintainer sergiusens noted the review comment asking for an integration test was already satisfied by existing coverage, and the PR was merged.

Evaluated by: mr-cal-bot

No scores available.

Issue body

The icon entry in snapcraft.yaml is now (again) the preferred method to have an icon in a snap, overriding the one in the `setup` directory if necessary too. LP: #1610268 Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #914 merged as commit 4a4435cbe, re-deprecating the icon deprecation: the icon entry in snapcraft.yaml is again the preferred method, overriding any icon in the setup directory (LP: #1610268).
stealth/space-bunny-alpha — closed resolved Merged #914, reversing icon deprecation: snapcraft.yaml's icon now takes precedence over setup-directory icons. Commit 4a4435cbe.
qwen/qwen3.6-35b-a3b — — Merged. Updates snapcraft to prioritize the icon field in snapcraft.yaml over the setup directory. Resolves LP #1610268 with minimal code changes.
qwen3.6-35b-a3b-mtp-q6 — — Merged. The icon entry in snapcraft.yaml is restored as the preferred method for specifying snap icons, overriding setup directory icons. Resolves LP #1610268.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#542 (confidence 55%)

    a9f2a7d7a (#542) updated icon documentation and follows the earlier icon-in-snapcraft.yaml work (#409/#407, commits b18e4e9bf, d460d9db1) that this change builds upon.

Related issues

Issue Project State Summary Similarity
#1561327 icon deprecation message doesn't explain the new way snapcraft (launchpad) closed Fixed by merged ubuntu-core/snapcraft PR #409, which clarified where to move the icon; merge commit 4073f89fc.
79%
#1610268 icon and license are deprecated snapcraft (launchpad) closed Icon paths in snapcraft.yaml were restored as preferred by canonical/snapcraft#914 (4a4435cbe); unsupported license metadata was removed by canonical/snapcraft#880 (1dab7aaed).
77%
#1578231 Your first snap: Use of icon in snapcraft.yaml is deprecated snapcraft (launchpad) closed Docs fixed in canonical/snapcraft#542 (commit a9f2a7d7a): the 'Your first snap' tutorial now tells users to place icon.png/icon.svg under setup/gui instead of the deprecated icon key. Shipped in snapcraft 2.10+16.10 and 2.10.1.
76%
#542 Updated the documentation about the icon. snapcraft merged Docs-only PR merged as a9f2a7d7a: tutorial no longer tells users to set `icon` in snapcraft.yaml (deprecated) but to place icon.svg/icon.png under setup/gui. Closes LP bug #1578231.
73%
#1567041 snapcraft init creates icon entry snapcraft (launchpad) closed Fixed by merged ubuntu-core/snapcraft#433 (commit af86cddce): snapcraft init no longer generates an icon entry.
72%
#409 Explain the new way to provide snap icons. snapcraft merged Merged guidance clarifying the supported way to provide snap icons in snapcraft.yaml, resolving LP #1561327 (merge 4073f89fc).
71%
#4936 snapcraft 7 ignores icon path in snapcraft.yaml snapcraft closed Regression in core22 Snapcraft 7 (icon not copied when no apps section) was fixed by merged PR #4950 (commit c9d9cc227, 'fix: configure icon for snaps without apps'), backported and released in 7.5.6 to 7.x/stable.
71%
#1662034 Adding "icon" filed in the snapcraft.yaml template to define a package icon snapcraft (launchpad) open The current `snapcraft init` template still omits icon guidance; the maintainer suggested a commented-out icon option, but no implementation followed.
70%