← Back to issue list

sources: refactor base sources into module.

View original Github issue

Metadata

Project
snapcraft
Number
#957
Type
pull request
State
merged
Author
kyrofa
Labels
—
Created
Updated
Closed

Current evaluation

Merged as commit 1d34e9e6b, extracting Base and FileBase into sources/_base.py and advancing the Launchpad #1648906 sources refactor.

Resolution: closed resolved

Reason: PR snapcraft#957 was approved and merged into master as commit 1d34e9e6b.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This PR makes progress on LP: [#1648906](https://bugs.launchpad.net/snapcraft/+bug/1648906) by extracting `Base` and `FileBase` sources into `sources/_base.py`.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged as commit 1d34e9e6b, extracting Base and FileBase into sources/_base.py and advancing the Launchpad #1648906 sources refactor.
stealth/space-bunny-alpha — closed resolved Merged in #957 as commit 1d34e9e6b, extracting Base and FileBase into sources/_base.py and advancing Launchpad #1648906.
qwen/qwen3.6-35b-a3b — — Merged following two approvals and passing CI checks. Refactored Base and FileBase sources into sources/_base.py, increasing test coverage by 1.20% and progressing work on Launchpad bug #1648906.
qwen3.6-35b-a3b-mtp-q6 — — Merged into master. Refactored Base and FileBase sources into a dedicated sources/_base.py module, increasing overall code coverage by 1.20% to 96.23%.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#953 sources: refactor base sources into new package. snapcraft closed Closed unmerged after review changes; successor PR snapcraft#957 completed the Base and FileBase extraction in commit 1d34e9e6b.
80%
#962 sources: refactor bazaar source into module. snapcraft merged Merged into master as commit 770607725, extracting Bazaar source handling into sources/_bazaar.py as progress on Launchpad bug #1648906.
73%
#969 sources: refactor tar source into module. snapcraft merged Merged PR #969 in commit 6fb798890, extracting the Tar source into sources/_tar.py as part of LP #1648906.
72%