sources: refactor base sources into module.
Metadata
Current evaluation
Merged following two approvals and passing CI checks. Refactored Base and FileBase sources into sources/_base.py, increasing test coverage by 1.20% and progressing work on Launchpad bug #1648906.
Suggested action: —
No scores available.
Issue body
This PR makes progress on LP: [#1648906](https://bugs.launchpad.net/snapcraft/+bug/1648906) by extracting `Base` and `FileBase` sources into `sources/_base.py`.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged following two approvals and passing CI checks. Refactored Base and FileBase sources into sources/_base.py, increasing test coverage by 1.20% and progressing work on Launchpad bug #1648906. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Refactored Base and FileBase sources into a dedicated sources/_base.py module, increasing overall code coverage by 1.20% to 96.23%. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Refactored Base and FileBase sources into a new sources/_base.py module, increasing overall code coverage by 1.20%. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #961 sources: refactor local source into module. | snapcraft | merged | Merged after approval and CI. Refactored the local source into sources/_local.py, advancing Launchpad bug #1648906. Modified four files with a +236/-191 line change and slightly increased overall code coverage. | |
| #967 sources: refactor script source into module. | snapcraft | merged | Merged refactoring of the Script source into a dedicated module at sources/_script.py, including basic unit tests. Approved, passed CI, and advances progress on Launchpad bug #1648906. | |
| #953 sources: refactor base sources into new package. | snapcraft | closed | Closed without merging after review requested changes. The base sources refactoring was abandoned or superseded by subsequent PRs, as the author noted this was the first in a series. | |
| #969 sources: refactor tar source into module. | snapcraft | merged | Merged a refactor extracting the Tar source into a dedicated module at sources/_tar.py. The change adds two files, increases code coverage by less than 0.01%, and advances work on Launchpad bug #1648906. | |
| #964 sources: refactor git source into module. | snapcraft | merged | Merged a refactor extracting Git source logic into sources/_git.py. Approved by reviewer, passed CI, and slightly improved code coverage as part of ongoing bug fix LP: #1648906. | |
| #214 feat: improve Launchpad base model and add tests | craft-application | merged | Merged following dual reviewer approval. The change enhances the Launchpad base model and introduces corresponding tests, modifying four files with a +129/-58 line diff. | |
| #968 sources: refactor subversion source into module. | snapcraft | merged | Merged refactoring that extracts the Subversion source handler into a dedicated module. Advances Launchpad bug #1648906, passed coverage checks, and received author approval. Net change: +170/-129 lines across four files. | |
| #966 sources: refactor rpm source into module. | snapcraft | merged | Merged a refactor extracting RPM source logic into a dedicated sources/_rpm.py module. Part of ongoing work on Launchpad bug #1648906, the change modified four files (+131/-90 lines) and slightly increased overall code coverage. | |
| #962 sources: refactor bazaar source into module. | snapcraft | merged | Merged refactoring that extracts the Bazaar source handler into a dedicated module at sources/_bazaar.py. Approved, passed CI, and slightly improved code coverage as part of ongoing bug resolution. |