← Back to issue list

style(lint): disable magic value check in tests

View original Github issue

Metadata

Project
starbase
Number
#151
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged to disable the magic value lint check in tests, resolving issue #148. Approved by three reviewers, passed CI checks, and maintained 100% test coverage with a single line change.

Suggested action: —

No scores available.

Issue body

fixes #148 - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged to disable the magic value lint check in tests, resolving issue #148. Approved by three reviewers, passed CI checks, and maintained 100% test coverage with a single line change.
qwen3.6-35b-a3b-mtp-q6 — — Disabled magic value lint checks in tests to resolve issue #148. The change was merged, maintained 100% test coverage, and integrated by maintainer lengau.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#528 style(lint): ignore FBT001 and FBT002 in tests starbase merged Merged. Updates lint configuration to ignore FBT001 and FBT002 rules in test files, as boolean arguments are standard testing patterns. Approved by two reviewers, passed CI checks, and applied with a minimal two-line change to align with the ecosystem.
75%
#5 style(lint): fix linting issues starflow merged Merged after approval. Resolved linting issues by modifying one file with three additions and three deletions. No unresolved comments or CI checks were present.
72%
#148 [DISCUSS] Disable magic value linter for tests? starbase closed Resolved. The PLR2004 magic value comparison rule will be disabled for test files. The private/protected method usage rule was also disabled for tests.
71%
#239 style(lint): autoformat starbase merged Merged after approval. Applied automated linting to a single file, adjusting one line. The maintainer requested the merge post-review, completed without CI checks or unresolved comments.
70%