← Back to issue list

style(lint): disable magic value check in tests

View original Github issue

Metadata

Project
starbase
Number
#151
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged #151 as commit 073e450, adding a test-only Ruff ignore for PLR2004 so magic values are allowed in tests; fixes #148.

Resolution: closed resolved

Reason: PR #151 merged as commit 073e450 and added PLR2004 to Ruff's tests/**.py per-file ignores. The PR explicitly fixes canonical/starbase#148.

Evaluated by: mr-cal-bot

No scores available.

Issue body

fixes #148 - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #151 as commit 073e450, adding a test-only Ruff ignore for PLR2004 so magic values are allowed in tests; fixes #148.
stealth/space-bunny-alpha — closed resolved Merged #151 to disable the magic-value lint check in tests, fixing #148. The one-line change was approved by three reviewers and preserved 100% test coverage.
qwen/qwen3.6-35b-a3b — — Merged to disable the magic value lint check in tests, resolving issue #148. Approved by three reviewers, passed CI checks, and maintained 100% test coverage with a single line change.
qwen3.6-35b-a3b-mtp-q6 — — Disabled magic value lint checks in tests to resolve issue #148. The change was merged, maintained 100% test coverage, and integrated by maintainer lengau.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/starbase#148 (confidence 100%)

    PR #151 explicitly states that it fixes #148; the merged lint change resolved that discussion.

Related issues

Issue Project State Summary Similarity
#148 [DISCUSS] Disable magic value linter for tests? starbase closed Resolved by merged PR canonical/starbase#151 (commit 073e450), adding PLR2004 ignores for tests. PR #150 also disabled private-member linting in tests.
81%
#351 linters: add PLR2004 to ruff ignore craft-parts merged Merged PR #351 added PLR2004 to Ruff's test ignores, suppressing over 600 magic-value warnings. Landed as commit 517f95d8.
80%
#1154 fix(lint): ignore PLR0917 in tests alongside PLR0913 craft-application merged Merged PR #1154 added Ruff PLR0917 to test per-file ignores alongside PLR0913, fixing nine fixture/parametrization lint failures; make lint-ruff passes.
77%