← Back to issue list

fix(lint): ignore PLR0917 in tests alongside PLR0913

View original Github issue

Metadata

Project
craft-application
Number
#1154
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #1154 added Ruff PLR0917 to test per-file ignores alongside PLR0913, fixing nine fixture/parametrization lint failures; make lint-ruff passes.

Resolution: closed resolved

Reason: PR #1154 was merged in commit b399df27, adding the test-specific PLR0917 exemption. All reported CI checks passed, including lint and tests.

Evaluated by: mr-cal-bot

No scores available.

Issue body

## Summary \`make lint-ruff\` was failing with 9 \`PLR0917\` (too many positional arguments) errors across several test files that use many fixtures and \`@pytest.mark.parametrize\` decorators. This extends the existing test per-file-ignore for \`PLR0913\` to also cover \`PLR0917\`, for the same reasoning: test functions often need many positional arguments for fixtures/parametrization. ## Testing \`make lint-ruff\` now passes cleanly.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #1154 added Ruff PLR0917 to test per-file ignores alongside PLR0913, fixing nine fixture/parametrization lint failures; make lint-ruff passes.
stealth/space-bunny-alpha — closed resolved Merged PR #1154 added PLR0917 to Ruff’s test per-file ignores alongside PLR0913, resolving nine fixture and parametrization lint errors; make lint-ruff passes.
qwen/qwen3.6-35b-a3b — — Merged a lint fix extending the PLR0913 test ignore to also suppress PLR0917. This resolves nine lint errors in test files caused by pytest fixtures and parametrization, allowing make lint-ruff to pass. Approved by two reviewers with all CI checks passing.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 5
Confidence: 95
needs review Extends test file lint ignore to cover PLR0917 alongside PLR0913, resolving 9 lint errors. Approved by 1 reviewer, all CI checks passing, ready to merge.
qwen/qwen3.6-35b-a3b
Staleness: 0
Complexity: 5
Confidence: 95
needs review Extends test lint ignore config to suppress PLR0917 alongside PLR0913. All CI checks pass, approved by one reviewer, and ready to merge.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 5
Confidence: 90
needs review Extends test file lint ignore configuration to suppress PLR0917 alongside PLR0913, resolving 9 lint errors. All CI checks pass, awaiting maintainer review.

Update history

Date Change
updated
updated
created

Related issues

Issue Project State Summary Similarity
#351 linters: add PLR2004 to ruff ignore craft-parts merged Merged PR #351 added PLR2004 to Ruff's test ignores, suppressing over 600 magic-value warnings. Landed as commit 517f95d8.
80%
#151 style(lint): disable magic value check in tests starbase merged Merged #151 as commit 073e450, adding a test-only Ruff ignore for PLR2004 so magic values are allowed in tests; fixes #148.
77%
#907 style: adjust linting rules for ruff 0.12 rockcraft merged Merged into main as 186cb0fb, updating Ruff 0.12 settings to ignore PLC0415 and avoid unnecessary noqa comments.
76%
#68 lint: update ruff and fix linting craft-archives merged Merged PR #68 as commit 8bb81ae, updating Ruff and fixing lint violations across four files after prerequisite #67.
75%
#4981 style(lint): fix ruff 0.6 linting errors snapcraft merged Merged PR #4981 as commit 3a1b8a949, fixing Ruff 0.6 lint errors with a minimal one-file change.
74%
#33 lint: fix lint issues with newer ruff craft-archives merged PR #33 merged as commit c2a6687, fixing new lint failures introduced by a newer Ruff release across3 files (+5/-3). Maintainer deferred extra unit tests to CRAFT-1641.
74%
#139 style: stricter ruff linters starbase merged PR #139 was merged as commit a48d590, adding stricter Ruff lint rules across six files while retaining 100% test coverage.
74%
#1577 style(lint): enable some previously-ignored ruff rules charmcraft merged Merged PR #1577 in commit 1b650062, enabling previously ignored Ruff rules and applying related lint/style changes across 10 files.
74%
#1737 style: fix linting for ruff 0.5 charmcraft merged Merged PR #1737 as commit 8994523e, updating one file (+2/-6) to fix linting under Ruff 0.5.
73%
#803 style: fix linting issues with ruff 0.12 craft-application merged Merged via commit 5e15ff09, fixing Ruff 0.12 lint failures across 14 files. A separate integration-test failure was fixed by #804.
73%