← Back to issue list

fix(lint): ignore PLR0917 in tests alongside PLR0913

View original Github issue

Metadata

Project
craft-application
Number
#1154
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged a lint fix extending the PLR0913 test ignore to also suppress PLR0917. This resolves nine lint errors in test files caused by pytest fixtures and parametrization, allowing make lint-ruff to pass. Approved by two reviewers with all CI checks passing.

Suggested action: —

No scores available.

Issue body

## Summary \`make lint-ruff\` was failing with 9 \`PLR0917\` (too many positional arguments) errors across several test files that use many fixtures and \`@pytest.mark.parametrize\` decorators. This extends the existing test per-file-ignore for \`PLR0913\` to also cover \`PLR0917\`, for the same reasoning: test functions often need many positional arguments for fixtures/parametrization. ## Testing \`make lint-ruff\` now passes cleanly.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged a lint fix extending the PLR0913 test ignore to also suppress PLR0917. This resolves nine lint errors in test files caused by pytest fixtures and parametrization, allowing make lint-ruff to pass. Approved by two reviewers with all CI checks passing.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 5
Confidence: 95
needs review Extends test file lint ignore to cover PLR0917 alongside PLR0913, resolving 9 lint errors. Approved by 1 reviewer, all CI checks passing, ready to merge.
qwen/qwen3.6-35b-a3b
Staleness: 0
Complexity: 5
Confidence: 95
needs review Extends test lint ignore config to suppress PLR0917 alongside PLR0913. All CI checks pass, approved by one reviewer, and ready to merge.
qwen/qwen3.6-35b-a3b
Staleness: 5
Complexity: 5
Confidence: 90
needs review Extends test file lint ignore configuration to suppress PLR0917 alongside PLR0913, resolving 9 lint errors. All CI checks pass, awaiting maintainer review.

Update history

Date Change
updated
updated
created

Related issues

Issue Project State Summary Similarity
#2819 fix(tests): resolve ruff lint failures in test suite charmcraft merged Merged fix for four ruff lint failures in the test suite. Resolved PLR0917 errors by marking extra pytest parameters as keyword-only, and fixed ISC004 errors by parenthesizing implicit string concatenations. Lint and test checks now pass.
84%
#33 lint: fix lint issues with newer ruff craft-archives merged Merged to resolve linting failures introduced by a newer ruff version. Changes fix style checks across three files. Review approved, CI passed, and coverage remained unchanged. Additional unit tests were deferred to a separate tracking ticket.
73%
#351 linters: add PLR2004 to ruff ignore craft-parts merged Merged adding PLR2004 to the ruff ignore list to suppress false positives for magic value comparisons in tests. Approved, passed CI, and updated the configuration file with one line.
73%
#528 style(lint): ignore FBT001 and FBT002 in tests starbase merged Merged. Updates lint configuration to ignore FBT001 and FBT002 rules in test files, as boolean arguments are standard testing patterns. Approved by two reviewers, passed CI checks, and applied with a minimal two-line change to align with the ecosystem.
72%
#995 fix: resolve ruff and mypy lint errors craft-providers merged Merged after fixing ruff and mypy lint errors. Changes wrap implicit string concatenations, adjust test ignores for positional arguments, and correct type ignores and redundant casts. All CI checks passed and the change was approved.
72%
#357 style: fix lints from ruff 0.12 craft-cli merged Merged following approval from three reviewers and successful CI checks. Resolved lint errors introduced by Ruff 0.12 across seven files with minor code adjustments.
72%
#803 style: fix linting issues with ruff 0.12 craft-application merged Merged after approval by two reviewers. Resolves linting failures introduced by ruff 0.12 across 14 files. CI passed for fast tests, linting, and security scans, while slow test failures were tracked separately in #804.
72%
#4981 style(lint): fix ruff 0.6 linting errors snapcraft merged Merged after receiving two approvals and passing CI checks. Resolves ruff 0.6 linting errors with a minimal one-file change.
72%
#675 style(lint): replace pylint with ruff rockcraft merged Merged a pull request replacing pylint with ruff for linting. The author updated CI configuration and requirements files to include ruff and remove pylint, ensuring all linters were properly enabled. Approved by reviewers and passed CI checks.
71%
#104 fix(lint-python): make the linter setup more resilient starflow merged Merged a fix to improve Python linter setup resilience. The change adds an apt update fallback to prevent failures when a package deb is removed. Approved by reviewers and passed all CI checks.
71%