fix: fix issues found in common.mk with charmcraft
Metadata
Current evaluation
Merged in canonical/starbase#289 (commit 0ffe5a7), fixing Charmcraft-related problems in common.mk.
Resolution: closed resolved
Reason: PR #289 was approved and merged into starbase. Commit 0ffe5a7 corrected the identified Charmcraft-related issues in common.mk.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/starbase#289 (commit 0ffe5a7), fixing Charmcraft-related problems in common.mk. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/starbase#289 (commit 0ffe5a7), correcting Charmcraft-related issues in common.mk. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix for charmcraft issues in common.mk. Approved by two reviewers with zero unresolved comments. Changed two files, adding 11 and removing 7 lines. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix addressing issues in common.mk related to charmcraft. The changes were integrated into the main branch without additional comments. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1619 fix: use charmcraft package version | charmcraft | merged | Merged PR #1619 as commit 15fac367, replacing the previous version source with the Charmcraft package version in a one-line fix. | |
| #501 fix: help formatting when running `make -f common.mk` | starbase | merged | Merged PR canonical/starbase#501 (commit 0344506) fixing help output formatting when running `make -f common.mk`; upported from canonical/rockcraft#1105. Approved by 2 reviewers, all CI checks passed. | |
| #2186 docs: fix build errors | charmcraft | merged | Merged as charmcraft/charmcraft#2186 in commit 42f42bd2, fixing the targeted docs build error. Remaining transclusion problems were addressed separately in canonical/craft-parts#1021. | |
| #215 fix(charm): accept redundant multi-base charms | craft-platforms | merged | Merged PR #215 as commit 4879309, allowing redundant multi-base charms when they produce equivalent valid build plans and addressing canonical/charmcraft#2620. | |
| #1467 ci(deps): use latest starbase for renovate | charmcraft | merged | Merged charmcraft#1467 in dc6853ee, updating Renovate to inherit the latest Canonical Starbase configuration. | |
| #2279 fix: bugfix updates and release for 3.4.6 | charmcraft | merged | Merged as commit 1abdb6d2, delivering Charmcraft 3.4.6 bugfix and release updates; the release branch was later merged into main by #2281. | |
| #1804 ci: update renovate from starbase | charmcraft | merged | Updated Renovate configuration and CI from canonical/starbase#232; merged in charmcraft#1804 at commit ddc3b1c8. | |
| #2070 docs: fix build errors in craft-parts | charmcraft | closed | Merged PR #2070, fixing Charmcraft ref and label build errors; remaining craft-parts errors depended on canonical/craft-parts#965. |