fix: fix issues found in common.mk with charmcraft
Metadata
Current evaluation
Merged a fix for charmcraft issues in common.mk. Approved by two reviewers with zero unresolved comments. Changed two files, adding 11 and removing 7 lines.
Suggested action: —
No scores available.
Issue body
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix for charmcraft issues in common.mk. Approved by two reviewers with zero unresolved comments. Changed two files, adding 11 and removing 7 lines. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix addressing issues in common.mk related to charmcraft. The changes were integrated into the main branch without additional comments. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1619 fix: use charmcraft package version | charmcraft | merged | Merged after approval from two reviewers. Implements a one-line fix to use the charmcraft package version, updating a single file to resolve the versioning configuration. | |
| #1622 fix: reorganise charmcraft.yaml preprocessing | charmcraft | merged | Merged following two approvals and passing CI. Reorganized charmcraft.yaml preprocessing to apply extensions on raw data, assign default parts to charms with bases, and enforce dictionary type for parts. Modified 5 files (+27/-14 lines). | |
| #188 Small text cleanups for README and charmcraft help | charmcraft | merged | Merged text cleanups for the README and charmcraft help documentation. Approved by two reviewers, the change updates 13 files to improve clarity while preserving test compatibility. | |
| #2154 docs: replace occurrences of "charmcraft.yaml" and "recipe" | charmcraft | merged | Merged documentation update replacing charmcraft.yaml and recipe with project or project file across 23 files. Approved by two reviewers after minor clarity feedback. Changes span +155/-159 lines. | |
| #1950 fix: make charmcraft work with snap parallel installs | charmcraft | merged | Merged to resolve issue #1770, enabling charmcraft to operate with snap parallel installs. Approved by two reviewers, the update modifies five files with 55 additions and 15 deletions. | |
| #2275 fix(charm): workaround to allow charmcraft-wide constraints | charmcraft | merged | Merged a workaround enabling charmcraft-wide constraints, resolving issue #2259 and CHARMCRAFT-614. Approved by two reviewers, the change modifies 15 files with 425 additions and passed CI checks prior to integration. | |
| #397 feat: add charmcraft inspector | fetch-service | merged | Merged the charmcraft inspector, verifying charmcraft.yaml existence. Approved by two reviewers, passed CI, and changed 7 files. The author addressed invocation order review comments prior to final merge. | |
| #46 New functionality from charmcraft (CRAFT-706). | craft-cli | merged | Merged new charmcraft functionality (CRAFT-706) following approval from two reviewers. The update adds approximately 2000 lines across 13 files, successfully integrating the feature set into the codebase. | |
| #142 fix the action generated by 'charmcraft init' | charmcraft | merged | Merged a fix for the action generated by charmcraft init, resolving issue #141. Approved by three reviewers and verified by the reporter. Corrects a generation bug in the init command. | |
| #380 Charmcraft imported improvements | starbase | merged | Merged minor import improvements for Charmcraft across two files. Approved by two reviewers and passed all CI checks before integration. |