fix: help formatting when running `make -f common.mk`
Metadata
Current evaluation
Merged upstream fix for help formatting when running make -f common.mk. Approved by two reviewers, passed all CI checks, and resolved via a single-line change.
Suggested action: —
No scores available.
Issue body
Upstreamed from https://github.com/canonical/rockcraft/pull/1105.
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/starbase/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [ ] I've successfully run `make lint && make test`.
~~- [ ] I've added or updated any relevant documentation.~~
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged upstream fix for help formatting when running make -f common.mk. Approved by two reviewers, passed all CI checks, and resolved via a single-line change. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for help formatting when running make -f common.mk. The change was upstreamed from canonical/rockcraft#1105 and successfully integrated. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1105 fix: correct common.mk help target listing | rockcraft | merged | Merged a fix for common.mk help target listing by preserving target names during Makefile parsing, resolving issue #941. Approved by three reviewers and merged after unrelated CI failures were confirmed as environmental noise. | |
| #324 fix(common.mk): docs ignores | starbase | merged | Merged a single-line update to common.mk that corrects documentation ignore patterns. The change received approval from two reviewers, passed CI validation, and implements fixes referenced in PR #2096. | |
| #413 fix: walk back pre-commit all-files | starbase | merged | Merged a fix to remove --all-files from pre-commit formatting to align with make format scope. Approved by two reviewers, passed all CI checks, and merged with a single-line change. | |
| #555 docs(build): fix typos in make help output | starbase | merged | Merged following approval by two reviewers and successful CI checks. The change corrected two typos in the make help output, updating a single file with a two-line modification. | |
| #542 fix: harden 'make help' for shell portability | starbase | merged | Merged to harden make help for shell portability, resolving issue 538. Approved by two reviewers with passing CI. A reviewer requested changing the commit prefix from fix to build for clearer history tracking before final merge. | |
| #332 fix(common.mk): fix glob of prettier files | starbase | merged | Merged a one-line update to common.mk that corrected the glob pattern for prettier files. Approved by one reviewer, the change was successfully integrated with zero unresolved comments and no CI failures. | |
| #2056 fix(common.mk): get upstream setup-lint | charmcraft | merged | Merged a fix to restore the upstream setup-lint target in common.mk after a pyright dependency removal caused a regression. Approved by two reviewers with zero unresolved comments. | |
| #2299 docs: fix formatting issues | charmcraft | merged | Merged documentation formatting fixes resolving local build errors. Approved by two reviewers with minimal changes (+3/-1 across two files). Merged despite failing snap-build CI checks. | |
| #586 fix: remove duplicate word in CONTRIBUTING.md | starbase | merged | Merged a one-line fix removing a duplicated word in CONTRIBUTING.md. Approved by one reviewer, passed all CI checks, and successfully integrated. | |
| #4065 cli: fix help message for the "upload" command | snapcraft | merged | Merged a one-line fix correcting a copy-paste error in the upload command help message. Approved by two reviewers, passed CI checks, and closed. |