← Back to issue list

fix: help formatting when running `make -f common.mk`

View original Github issue

Metadata

Project
starbase
Number
#501
Type
pull request
State
merged
Author
medubelko
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR canonical/starbase#501 (commit 0344506) fixing help output formatting when running `make -f common.mk`; upported from canonical/rockcraft#1105. Approved by 2 reviewers, all CI checks passed.

Resolution: closed resolved

Reason: The PR itself was merged into main as commit 0344506 with all CI checks green, delivering the one-line common.mk help-formatting fix carried over from rockcraft#1105.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Upstreamed from https://github.com/canonical/rockcraft/pull/1105. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/starbase/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [ ] I've successfully run `make lint && make test`. ~~- [ ] I've added or updated any relevant documentation.~~

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR canonical/starbase#501 (commit 0344506) fixing help output formatting when running `make -f common.mk`; upported from canonical/rockcraft#1105. Approved by 2 reviewers, all CI checks passed.
stealth/space-bunny-alpha — closed resolved Merged in canonical/starbase#501 (0344506), upstreaming rockcraft#1105 to correct common.mk help target-name formatting.
qwen/qwen3.6-35b-a3b — — Merged upstream fix for help formatting when running make -f common.mk. Approved by two reviewers, passed all CI checks, and resolved via a single-line change.
qwen3.6-35b-a3b-mtp-q6 — — Merged a fix for help formatting when running make -f common.mk. The change was upstreamed from canonical/rockcraft#1105 and successfully integrated.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/rockcraft#1105 (confidence 92%)

    Stated in the PR body as the original upstream fix that was ported to starbase.

Related issues

Issue Project State Summary Similarity
#336 docs: fix some formatting errors in README starbase merged Docs-only PR merged as commit d3d4189, adding 10 lines to starbase's README to fix spacing/formatting errors that slipped past the earlier README cleanup in #331 (commit de0d308). Approved by 2 reviewers, no CI.
73%
#929 fix: install system packages when running `make setup` rockcraft merged Merged in canonical/rockcraft#929, updating make setup to install required system packages through cherry-picked Starbase changes.
73%
#289 fix: fix issues found in common.mk with charmcraft starbase merged Merged in canonical/starbase#289 (commit 0ffe5a7), fixing Charmcraft-related problems in common.mk.
73%
#31 tools: fix the PR template name starbase merged Merged canonical/starbase#31 as commit f4774ed, correcting the GitHub PR template filename without changing its contents.
72%
#1105 fix: correct common.mk help target listing rockcraft merged Merged PR #1105 as commit 6ae769e9, preserving Makefile target names in common.mk help output and fixing #941.
71%
#785 fix: remove Starbase README craft-application merged PR #785 merged as commit d6b706a3, deleting the 144-line Starbase-rendered .github/README.md from craft-application. Approved by 2 reviewers; lint/tests/builds passed (OSV-scanner failed, non-blocking).
70%