← Back to issue list

style: enforce strict checking for shadowing

View original Github issue

Metadata

Project
starbase
Number
#368
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged upstream changes enforcing strict variable shadowing checks. Approved by two reviewers, passed CI, and added three lines to one file. Implements style enforcement for the repository.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? --- Upstream of https://github.com/canonical/craft-parts/pull/1045.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged upstream changes enforcing strict variable shadowing checks. Approved by two reviewers, passed CI, and added three lines to one file. Implements style enforcement for the repository.
qwen3.6-35b-a3b-mtp-q6 Merged a style update enforcing strict variable shadowing checks across the codebase. This establishes the upstream foundation for craft-parts pull request #1045, enhancing linting standards and preventing bugs from shadowed identifiers.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1045 style: enforce strict checking for shadowing craft-parts merged Merged after approval. Updates Ruff configuration to enforce strict module shadowing checks, maintaining previous strictness after Ruff 0.10 relaxed the default rule. Approved by two reviewers and passed CI.
76%
#6266 style: ignore configparser shadowing snapcraft merged Merged a change to suppress a Ty linter warning about configparser shadowing. Added a style ignore directive to avoid unnecessary subclassing. Approved by two reviewers and passed CI checks.
71%