← Back to issue list

style: ignore configparser shadowing

View original Github issue

Metadata

Project
snapcraft
Number
#6266
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged a change to suppress a Ty linter warning about configparser shadowing. Added a style ignore directive to avoid unnecessary subclassing. Approved by two reviewers and passed CI checks.

Suggested action: —

No scores available.

Issue body

Ty no longer likes the typing change from #6247. The alternative is to subclass and override, but the configparser docs are adamant that you don't need to subclass to do this. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b — — Merged a change to suppress a Ty linter warning about configparser shadowing. Added a style ignore directive to avoid unnecessary subclassing. Approved by two reviewers and passed CI checks.
qwen3.6-35b-a3b-mtp-q6 — — Merged a style fix to suppress a configparser shadowing warning from the Ty linter. The change explicitly ignores the warning rather than subclassing, resolving a linting conflict from a prior update.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1361 style: suppress ty warning rockcraft merged Merged a one-line change to suppress a ty 0.0.79 false positive on user_files["shadow"]. Approved by one reviewer and passed CI checks.
71%
#368 style: enforce strict checking for shadowing starbase merged Merged upstream changes enforcing strict variable shadowing checks. Approved by two reviewers, passed CI, and added three lines to one file. Implements style enforcement for the repository.
71%