← Back to issue list

Add .venv removal to make clean

View original Github issue

Metadata

Project
starbase
Number
#461
Type
pull request
State
merged
Author
Copilot
Labels
Created
Updated
Closed

Current evaluation

Merged. Added .venv to the make clean target in common.mk to enable full virtual environment recreation. Approved by three reviewers, passed CI checks, and resolves canonical/starbase#460.

Suggested action:

No scores available.

Issue body

The `make clean` target removes build artifacts but leaves the uv-managed virtual environment intact, preventing a true clean slate rebuild. ## Changes - Added `.venv` to the `rm -rf` command in the `clean` target in `common.mk` This aligns with the existing `.gitignore` which already excludes `.venv`, and enables full environment recreation via `make clean && make setup`. <!-- START COPILOT CODING AGENT SUFFIX --> <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>`make clean` should remove the virtual environment as well.</issue_title> > <issue_description>When a developer runs `make clean`, it should also remove the virtual environment that ruff sets up so it can be recreated from scratch.</issue_description> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > </comments> > </details> - Fixes canonical/starbase#460 <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey).

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Added .venv to the make clean target in common.mk to enable full virtual environment recreation. Approved by three reviewers, passed CI checks, and resolves canonical/starbase#460.
qwen3.6-35b-a3b-mtp-q6 Merged. Added .venv removal to the make clean target in common.mk. This ensures the virtual environment is deleted during cleanup, enabling full environment recreation and resolving issue #460.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3941 lint: support the existence of 'venv' snapcraft merged Merged after reviewer approval and passing CI. Adds 'venv' and '.venv' to .gitignore and configures codespell to skip these common virtual environment directories.
70%
#3936 lint: support the existence of 'venv' snapcraft closed Merged into main. Added 'venv' to .gitignore and codespell skip list to prevent linting errors for common virtual environment directories. Approved by one reviewer with passing CI checks.
70%